Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/native_theme/native_theme.h

Issue 1020623002: [AiS] adding positive and negative theme values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comments for positive and negative text Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/native_theme/fallback_theme.cc ('k') | ui/native_theme/native_theme_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/native_theme/native_theme.h
diff --git a/ui/native_theme/native_theme.h b/ui/native_theme/native_theme.h
index a17b9c14b79d5d4f29f2af07db8b2dd720dd6b87..3f47ad922bd179d39bb91382c78c9ec9b1bdd732 100644
--- a/ui/native_theme/native_theme.h
+++ b/ui/native_theme/native_theme.h
@@ -298,7 +298,7 @@ class NATIVE_THEME_EXPORT NativeTheme {
kColorId_TableSelectionBackgroundFocused,
kColorId_TableSelectionBackgroundUnfocused,
kColorId_TableGroupingIndicatorColor,
- // Results Tables, such as the chrome omnibox.
+ // Results Tables, such as the omnibox.
kColorId_ResultsTableNormalBackground,
kColorId_ResultsTableHoveredBackground,
kColorId_ResultsTableSelectedBackground,
@@ -314,6 +314,16 @@ class NATIVE_THEME_EXPORT NativeTheme {
kColorId_ResultsTableNormalDivider,
kColorId_ResultsTableHoveredDivider,
kColorId_ResultsTableSelectedDivider,
+ // Positive text refers to good (often rendered in green) text, such as the
+ // stock value went up.
+ kColorId_ResultsTablePositiveText,
+ kColorId_ResultsTablePositiveHoveredText,
+ kColorId_ResultsTablePositiveSelectedText,
+ // Negative text refers to something alarming (often rendered in red), such
+ // as the stock value went down.
+ kColorId_ResultsTableNegativeText,
+ kColorId_ResultsTableNegativeHoveredText,
+ kColorId_ResultsTableNegativeSelectedText,
// TODO(benrg): move other hardcoded colors here.
kColorId_NumColors,
« no previous file with comments | « ui/native_theme/fallback_theme.cc ('k') | ui/native_theme/native_theme_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698