[AiS] adding positive and negative theme values

[AiS] adding positive and negative theme values.

This is a step toward having color text for things like an increase in stock price (positive) and a decrease in stock value (negative).  An example would be the text shown in Answers in Suggest.

This CL is groundwork for (and separated out from) CL 795933009.

BUG=455418
Committed: https://crrev.com/362e17dd968c9a8ee263ab5b7171b336f0119e0e
Cr-Commit-Position: refs/heads/master@{#321586}

[dschuyler, 2015-03-18 21:55:23]

dschuyler@chromium.org changed reviewers:
+ estade@chromium.org, sadrul@chromium.org

[Peter Kasting, 2015-03-18 22:00:04]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-03-18 22:00:04]

Please fill in the BUG= line.

LGTM

https://codereview.chromium.org/1020623002/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc (right):

https://codereview.chromium.org/1020623002/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc:97: GdkColor
GetReadableColor(uint32_t color, const GdkColor& background) {
Use SkColor here, not uint32_t.

[dschuyler, 2015-03-18 22:00:13]

dschuyler@chromium.org changed reviewers:
- pkasting@chromium.org

[dschuyler, 2015-03-18 22:00:13]

I removed an unnecessary change to native_theme_win.cc.

[dschuyler, 2015-03-18 22:03:35]

https://codereview.chromium.org/1020623002/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc (right):

https://codereview.chromium.org/1020623002/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc:97: GdkColor
GetReadableColor(uint32_t color, const GdkColor& background) {
On 2015/03/18 22:00:04, Peter Kasting wrote:
> Use SkColor here, not uint32_t.

Done.

[Peter Kasting, 2015-03-18 22:25:10]

On 2015/03/18 22:00:13, dschuyler wrote:
> I removed an unnecessary change to native_theme_win.cc.

Unrevert that, that change was a good one.

[dschuyler, 2015-03-18 22:37:03]

Unreverted the GetReadableColor call.

[Evan Stade, 2015-03-19 16:18:26]

gtk lgtm

[dschuyler, 2015-03-19 17:50:14]

On 2015/03/19 16:18:26, Evan Stade wrote:
> gtk lgtm

Hi Sadrul, may I get your lgtm

[msw, 2015-03-19 19:38:38]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2015-03-19 19:38:39]

This doesn't address my concerns regarding the ad-hoc application of readable
color modifications and blending from:
https://codereview.chromium.org/795933009/diff/620001/ui/native_theme/native_...

[Peter Kasting, 2015-03-19 20:12:13]

On 2015/03/19 19:38:39, msw wrote:
> This doesn't address my concerns regarding the ad-hoc application of readable
> color modifications and blending from:
>
https://codereview.chromium.org/795933009/diff/620001/ui/native_theme/native_...

See my replies to your comments there.  In short, I believe Dave's changes are
correct and your suggestions are not, so I support landing this change as-is.

[sadrul, 2015-03-19 20:19:16]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org
- sadrul@chromium.org

[sadrul, 2015-03-19 20:19:17]

+sky@

Sounds like there's some disagreements over the best approach, and I don't know
enough to have any good feedback. So replacing myself with sky@ for owner
review.

[msw, 2015-03-19 21:39:24]

Peter's explanation in the other CL makes sense; lgtm.

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/fallbac...
File ui/native_theme/fallback_theme.cc (right):

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/fallbac...
ui/native_theme/fallback_theme.cc:99: kTextfieldSelectionBackgroundFocused,
0xDD);
nit: we could drop 'Focused' from this constant and from the constant
kColorId_TextfieldSelectionBackgroundFocused, but that's not necessary now.

[Peter Kasting, 2015-03-19 22:17:53]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-03-19 22:17:53]

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/fallbac...
File ui/native_theme/fallback_theme.cc (right):

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/fallbac...
ui/native_theme/fallback_theme.cc:99: kTextfieldSelectionBackgroundFocused,
0xDD);
On 2015/03/19 21:39:23, msw wrote:
> nit: we could drop 'Focused' from this constant and from the constant
> kColorId_TextfieldSelectionBackgroundFocused, but that's not necessary now.

Good call, added that to the cleanup bug I have on file against Dave.

[sky, 2015-03-19 23:54:31]

It looks like everyone is happy now. I have one request, LGTM after adding
better documentation.

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/native_...
File ui/native_theme/native_theme.h (right):

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/native_...
ui/native_theme/native_theme.h:317: kColorId_ResultsTablePositiveText,
These constants need descriptions. Positive/Negative are obscure and tell me
nothing about what they mean.

[dschuyler, 2015-03-20 02:03:53]

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/native_...
File ui/native_theme/native_theme.h (right):

https://codereview.chromium.org/1020623002/diff/80001/ui/native_theme/native_...
ui/native_theme/native_theme.h:317: kColorId_ResultsTablePositiveText,
On 2015/03/19 23:54:31, sky wrote:
> These constants need descriptions. Positive/Negative are obscure and tell me
> nothing about what they mean.

Done.

[dschuyler, 2015-03-20 17:18:25]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-03-20 17:18:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, msw@chromium.org, sky@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1020623002/#ps100001
(title: "Added comments for positive and negative text")

[commit-bot: I haz the power, 2015-03-20 17:18:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020623002/100001

[commit-bot: I haz the power, 2015-03-20 17:22:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-20 17:23:57]

Patchset 6 (id:??) landed as
https://crrev.com/362e17dd968c9a8ee263ab5b7171b336f0119e0e
Cr-Commit-Position: refs/heads/master@{#321586}