Issue 1020603002: [Win] Don't crash when updating tooltip and the ClientView hasn't been added to the view hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1020603002: [Win] Don't crash when updating tooltip and the ClientView hasn't been added to the view hierarchy. (Closed)

Created:
5 years, 9 months ago by noms (inactive)

Modified:
5 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Win] Don't crash when updating tooltip and the ClientView hasn't been added to the view hierarchy. BUG=467473 Committed: https://crrev.com/73f4c306d69d51e5cd580b74d8cbf5820c4e3c67 Cr-Commit-Position: refs/heads/master@{#321227}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	ui/views/widget/tooltip_manager_aura.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

noms (inactive)

PTAL. Thanks! (for the fix, and for the review) :)

5 years, 9 months ago (2015-03-18 20:07:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020603002/1

5 years, 9 months ago (2015-03-18 21:05:17 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-18 22:55:54 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/73f4c306d69d51e5cd580b74d8cbf5820c4e3c67
Cr-Commit-Position: refs/heads/master@{#321227}