Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1020593003: Ensure that we use different glyph entries for regular and df text. (Closed)

Created:
5 years, 9 months ago by jvanverth1
Modified:
5 years, 9 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Ensure that we use different glyph entries for regular and df text. Currently if we switch between regular text and df text while using the same GrContext, they may use the same entry in the Ganesh font cache, which is incorrect. This change ensures that they will have different entries. Committed: https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034 Committed: https://skia.googlesource.com/skia/+/a7634619ec653e94a8a506ca86c233753d10510e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M src/gpu/GrBitmapTextContext.cpp View 6 chunks +11 lines, -6 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrFontCache.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/gpu/GrFontCache.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrGlyph.h View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jvanverth1
5 years, 9 months ago (2015-03-18 19:21:16 UTC) #2
joshualitt
On 2015/03/18 19:21:16, jvanverth1 wrote: lgtm
5 years, 9 months ago (2015-03-18 19:24:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020593003/20001
5 years, 9 months ago (2015-03-18 21:41:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034
5 years, 9 months ago (2015-03-18 21:46:41 UTC) #6
jvanverth1
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1011403005/ by jvanverth@google.com. ...
5 years, 9 months ago (2015-03-18 22:13:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020593003/20001
5 years, 9 months ago (2015-03-19 13:08:21 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:08:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a7634619ec653e94a8a506ca86c233753d10510e

Powered by Google App Engine
This is Rietveld 408576698