Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 1020573002: Let's find out what's up with the TSAN bot test failures. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
rmistry, egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Let's find out what's up with the TSAN bot test failures. BUG=skia: Committed: https://skia.googlesource.com/skia/+/97ca98d74e1a79798d7786cd4716c779380dc57f

Patch Set 1 #

Patch Set 2 : errorf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/MathTest.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
Any LGTM will do. I suspect this has something to do with bot upgrades, but ...
5 years, 9 months ago (2015-03-18 18:24:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020573002/20001
5 years, 9 months ago (2015-03-18 18:24:43 UTC) #4
rmistry
Your own lgtm seemed to have worked :)
5 years, 9 months ago (2015-03-18 18:25:22 UTC) #5
mtklein
On 2015/03/18 18:25:22, rmistry wrote: > Your own lgtm seemed to have worked :) Oh. ...
5 years, 9 months ago (2015-03-18 18:25:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 18:32:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/97ca98d74e1a79798d7786cd4716c779380dc57f

Powered by Google App Engine
This is Rietveld 408576698