Fire an event when a menu list option becomes unselected.

Fire an event when a menu list option becomes unselected.

Previously we only had an event for gaining selection.

BUG=323462
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192487

[dmazzoni, 2015-03-19 07:00:57]

dmazzoni@chromium.org changed reviewers:
+ je_julie.kim@samsung.com

[Mike West, 2015-03-19 12:34:21]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-03-19 12:34:21]

LGTM % nit.

https://codereview.chromium.org/1020473004/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXMenuListPopup.h (right):

https://codereview.chromium.org/1020473004/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXMenuListPopup.h:62: int m_activeIndex;
This would be better as `unsigned`, as allowing negative indices into arrays is
not a wonderful idea. But, looking at HTMLSelectElement, there doesn't seem to
be anything else you could hook into. That's unfortunate. :/

Would you mind adding a note about `-1`'s magicness?

[je_julie(Not used), 2015-03-20 00:15:04]

LGTM!

[dmazzoni, 2015-03-20 04:56:37]

https://codereview.chromium.org/1020473004/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXMenuListPopup.h (right):

https://codereview.chromium.org/1020473004/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXMenuListPopup.h:62: int m_activeIndex;
On 2015/03/19 12:34:21, Mike West wrote:
> This would be better as `unsigned`, as allowing negative indices into arrays
is
> not a wonderful idea. But, looking at HTMLSelectElement, there doesn't seem to
> be anything else you could hook into. That's unfortunate. :/
> 
> Would you mind adding a note about `-1`'s magicness?

Good idea, done.

[dmazzoni, 2015-03-20 04:56:57]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-03-20 04:57:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020473004/1

[dmazzoni, 2015-03-24 23:07:47]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-03-24 23:07:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
je_julie.kim@samsung.com, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1020473004/#ps20001
(title: "Add comment about selectedIndex=-1")

[commit-bot: I haz the power, 2015-03-24 23:08:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020473004/20001

[commit-bot: I haz the power, 2015-03-25 00:33:22]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192487