Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1020453002: Introduce explicit constant for per Context debug data set by embedder (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr., kozy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce explicit constant for per Context debug data set by embedder It's value is hardwired in gin[1] and is referenced in Blink[2]. Since it is treated specially by v8 debugger it should be defined in v8 API and referenced in gin and blink.. [1] https://src.chromium.org/viewvc/chrome/trunk/src/gin/public/context_holder.h?r1=239099&r2=239098&pathrev=239099 [2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp&q=kDebugIdIndex%20f:V8PerContextData&sq=package:chromium&type=cs BUG=chromium:466631 LOG=Y Committed: https://crrev.com/c622cb637a2831f9c2bf0ec7b80bb65440e9afc4 Cr-Commit-Position: refs/heads/master@{#27290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M include/v8.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
yurys
5 years, 9 months ago (2015-03-18 10:20:09 UTC) #3
Yang
On 2015/03/18 10:20:09, yurys wrote: LGTM.
5 years, 9 months ago (2015-03-18 12:31:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020453002/1
5 years, 9 months ago (2015-03-18 12:51:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1330)
5 years, 9 months ago (2015-03-18 13:03:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020453002/1
5 years, 9 months ago (2015-03-18 13:06:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1333)
5 years, 9 months ago (2015-03-18 13:08:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020453002/1
5 years, 9 months ago (2015-03-19 08:17:20 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 08:18:40 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 08:18:54 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c622cb637a2831f9c2bf0ec7b80bb65440e9afc4
Cr-Commit-Position: refs/heads/master@{#27290}

Powered by Google App Engine
This is Rietveld 408576698