Issue 1020363004: Port -fsanitize=cfi-vptr flags to Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1020363004: Port -fsanitize=cfi-vptr flags to Mac. (Closed)

Created:
5 years, 9 months ago by pcc1

Modified:
5 years, 9 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Port -fsanitize=cfi-vptr flags to Mac. BUG=469377 R=thakis@chromium.org Committed: https://crrev.com/0936eea4c304e427d5fd6c6b4bf0a296eb4c9cb6 Cr-Commit-Position: refs/heads/master@{#321829}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

lgtm About your exclusion question, I remembered that I did this before: https://code.google.com/p/chromium/codesearch#chromium/src/build/set_clang_warning_flags.gypi&l=40 so the ...

5 years, 9 months ago (2015-03-21 03:49:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020363004/1

5 years, 9 months ago (2015-03-23 18:22:39 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-23 19:30:27 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0936eea4c304e427d5fd6c6b4bf0a296eb4c9cb6
Cr-Commit-Position: refs/heads/master@{#321829}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages