Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1020333002: Declare string16 traits’ move() correctly (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/strings/string16.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-20 18:14:16 UTC) #2
danakj
LGTM
5 years, 9 months ago (2015-03-20 18:17:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd697fc2963b8adccc629356fd94cbc08f3b9880 Cr-Commit-Position: refs/heads/master@{#321610}
5 years, 9 months ago (2015-03-20 19:13:15 UTC) #4
Mark Mentovai
5 years, 9 months ago (2015-03-20 19:13:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd697fc2963b8adccc629356fd94cbc08f3b9880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698