Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: public/platform/modules/presentation/WebPresentationSessionClient.h

Issue 1020303004: [PresentationAPI] Plumbing |onstatechange| event for the PresentationSession from Blink to platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/presentation/WebPresentationSessionClient.h
diff --git a/public/platform/modules/presentation/WebPresentationSessionClient.h b/public/platform/modules/presentation/WebPresentationSessionClient.h
index 735ff3cd1602ac6c935cd078eb372a9b416930d3..641482049abb1e5e4878a675cf61129445450fe4 100644
--- a/public/platform/modules/presentation/WebPresentationSessionClient.h
+++ b/public/platform/modules/presentation/WebPresentationSessionClient.h
@@ -12,6 +12,13 @@ namespace blink {
// The implementation the embedder has to provide for the Presentation API to work.
class WebPresentationSessionClient {
public:
+ enum SessionState {
mlamouri (slow - plz ping) 2015/03/23 17:54:16 Could you make this an enum class? It will requir
whywhat 2015/03/23 21:12:16 Done.
+ SessionStateConnected = 0,
+ SessionStateDisconnected,
+ SessionStateUnknown,
Peter Beverloo 2015/03/20 19:07:40 When would we use "Unknown"?
whywhat 2015/03/23 21:12:16 When WFT happens?
+ SessionStateLast = SessionStateUnknown
mlamouri (slow - plz ping) 2015/03/23 17:54:16 Do you use SessionStateLast? It is commonly used f
whywhat 2015/03/23 21:12:17 No, I have it for consistency only.
+ };
+
virtual ~WebPresentationSessionClient() { }
virtual WebString getId() = 0;

Powered by Google App Engine
This is Rietveld 408576698