[PresentationAPI] Plumbing |onstatechange| event for the PresentationSession from Blink to platform/

public/platform/modules/presentation/WebPresentationController.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebPresentationController_h
 #define WebPresentationController_h
 
+#include "public/platform/modules/presentation/WebPresentationSessionClient.h"

[mlamouri (slow - plz ping), 2015/03/23 17:54:16]

You should make the enum an enum class so you can forward declare it.

[whywhat, 2015/03/23 21:12:16]

Done.

+
 namespace blink {
 
-class WebPresentationSessionClient;
-
 // The delegate Blink provides to WebPresentationClient in order to get updates.
 class WebPresentationController {
 public:
     virtual ~WebPresentationController() { }
 
     // Called when the presentation screen availability changes.
     // May not be called if there's no registered listener for the event.
     virtual void didChangeAvailability(bool available) = 0;
 
     // Indicates if the frame has listeners to the |availablechange| event.
     virtual bool isAvailableChangeWatched() const = 0;
 
     // Called when the presentation session is started by the embedder using
     // the default presentation URL and id.
     virtual void didStartDefaultSession(WebPresentationSessionClient*) = 0;
+
+    // Called when the state of a session changes.
+    virtual void didChangeSessionState(WebPresentationSessionClient*, WebPresentationSessionClient::SessionState) = 0;

[Peter Beverloo, 2015/03/20 19:07:40]

This means that the Chromium patch has to land first, otherwise you'll have
unresolved pure virtual methods in your class. The patch' descriptions don't
agree.

[Peter Beverloo, 2015/03/20 19:16:59]

Scrap that :-).

[whywhat, 2015/03/23 21:12:16]

Acknowledged.

[whywhat, 2015/03/23 21:12:16]

Acknowledged.

 };
 
 } // namespace blink
 
 #endif // WebPresentationController_h