Force --enable-webkit-text-subpixel-positioning for DSF > 1.0.

Force --enable-webkit-text-subpixel-positioning for DSF > 1.0.

We already do this for fonts in the UI, and we should also do this for fonts in
the actual web content (i.e. everywhere where chromium falls back on an
operating system font, e.g. when specifying just “monospace”).

before this change:
http://t.zekjur.net/2015-03-21-003244_2357x1809_scrot.png

after this change:
http://t.zekjur.net/2015-03-21-003308_2357x1775_scrot.png

BUG=396659, 143619
Committed: https://crrev.com/442a5a6b163e6f9f7d798b5501c5143367e5c8c7
Cr-Commit-Position: refs/heads/master@{#323085}

[stapelberg, 2015-03-20 23:35:32]

stapelberg@google.com changed reviewers:
+ derat@chromium.org

[stapelberg, 2015-03-20 23:36:37]

Daniel, can you please take a look at this simple change? After reading
https://code.google.com/p/chromium/issues/detail?id=396659 I believe you wanted
to do a refactoring to remove this flag with a wider scope anyway, but I think
having this stop-gap solution land until you get around to the proper removal is
worthwhile for all hi-dpi users on linux.

Thank you.

[Daniel Erat, 2015-03-20 23:51:49]

derat@chromium.org changed reviewers:
+ oshima@chromium.org

[Daniel Erat, 2015-03-20 23:51:50]

this looks fine to me, but i'm adding oshima to make sure it aligns with any
plans that he has.

i'm unlikely to get around to taking another shot at removing the subpixel
positioning setting from blink. the layout tests there are a disaster (multiple
layers of font-related caches that don't get cleared between tests) and i'm
working on other things now.

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
File ui/gfx/font_render_params_linux.cc (left):

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
ui/gfx/font_render_params_linux.cc:256:
switches::kEnableWebkitTextSubpixelPositioning)
this looks like it was the only place where this flag was used, so please remove
the other three references to the constant from chrome as well.

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
File ui/gfx/font_render_params_linux.cc (right):

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
ui/gfx/font_render_params_linux.cc:252: // flag.
please delete this now-obsolete comment.

[oshima, 2015-03-21 00:09:26]

On 2015/03/20 23:51:50, Daniel Erat wrote:
> this looks fine to me, but i'm adding oshima to make sure it aligns with any
> plans that he has.

I'm just working on the CL to eliminate the flag (crrev.com/1023343003) :)
Hopefully, we can remove this all together.

> 
> i'm unlikely to get around to taking another shot at removing the subpixel
> positioning setting from blink. the layout tests there are a disaster
(multiple
> layers of font-related caches that don't get cleared between tests) and i'm
> working on other things now.
> 
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> File ui/gfx/font_render_params_linux.cc (left):
> 
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> ui/gfx/font_render_params_linux.cc:256:
> switches::kEnableWebkitTextSubpixelPositioning)
> this looks like it was the only place where this flag was used, so please
remove
> the other three references to the constant from chrome as well.
> 
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> File ui/gfx/font_render_params_linux.cc (right):
> 
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> ui/gfx/font_render_params_linux.cc:252: // flag.
> please delete this now-obsolete comment.

[oshima, 2015-03-31 17:50:42]

I decided to change the direction of my CL a bit, so please go ahead alnd land
this. This CL won't do any harm to my changes, and I'll cleanup when my part is
done.

lgtm once you addressed derat@'s comment.

On 2015/03/21 00:09:26, oshima wrote:
> On 2015/03/20 23:51:50, Daniel Erat wrote:
> > this looks fine to me, but i'm adding oshima to make sure it aligns with any
> > plans that he has.
> 
> I'm just working on the CL to eliminate the flag (crrev.com/1023343003) :)
> Hopefully, we can remove this all together.
> 
> > 
> > i'm unlikely to get around to taking another shot at removing the subpixel
> > positioning setting from blink. the layout tests there are a disaster
> (multiple
> > layers of font-related caches that don't get cleared between tests) and i'm
> > working on other things now.
> > 
> >
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> > File ui/gfx/font_render_params_linux.cc (left):
> > 
> >
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> > ui/gfx/font_render_params_linux.cc:256:
> > switches::kEnableWebkitTextSubpixelPositioning)
> > this looks like it was the only place where this flag was used, so please
> remove
> > the other three references to the constant from chrome as well.
> > 
> >
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> > File ui/gfx/font_render_params_linux.cc (right):
> > 
> >
>
https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
> > ui/gfx/font_render_params_linux.cc:252: // flag.
> > please delete this now-obsolete comment.

[stapelberg, 2015-03-31 18:11:57]

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
File ui/gfx/font_render_params_linux.cc (left):

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
ui/gfx/font_render_params_linux.cc:256:
switches::kEnableWebkitTextSubpixelPositioning)
On 2015/03/20 23:51:50, Daniel Erat wrote:
> this looks like it was the only place where this flag was used, so please
remove
> the other three references to the constant from chrome as well.

Done.

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
File ui/gfx/font_render_params_linux.cc (right):

https://codereview.chromium.org/1020263004/diff/1/ui/gfx/font_render_params_l...
ui/gfx/font_render_params_linux.cc:252: // flag.
On 2015/03/20 23:51:50, Daniel Erat wrote:
> please delete this now-obsolete comment.

Done.

[stapelberg, 2015-03-31 18:13:13]

stapelberg@google.com changed reviewers:
+ sadrul@chromium.org

[stapelberg, 2015-03-31 18:13:14]

sadrul, can you take a look at this for OWNERS approval please?

[sadrul, 2015-03-31 18:20:06]

lgtm

https://codereview.chromium.org/1020263004/diff/20001/ui/gfx/font_render_para...
File ui/gfx/font_render_params_linux.cc (left):

https://codereview.chromium.org/1020263004/diff/20001/ui/gfx/font_render_para...
ui/gfx/font_render_params_linux.cc:254: actual_query.for_web_contents
Looks like this was the only use of |FondRenderParamsQuery::for_web_contents|?
Can this now be removed?

[stapelberg, 2015-03-31 18:29:29]

https://codereview.chromium.org/1020263004/diff/20001/ui/gfx/font_render_para...
File ui/gfx/font_render_params_linux.cc (left):

https://codereview.chromium.org/1020263004/diff/20001/ui/gfx/font_render_para...
ui/gfx/font_render_params_linux.cc:254: actual_query.for_web_contents
On 2015/03/31 18:20:06, sadrul wrote:
> Looks like this was the only use of |FondRenderParamsQuery::for_web_contents|?
> Can this now be removed?

Yes, I think so. I’ll do that in a separate CL though, since it touches a lot of
files and would delay landing this change significantly. :)

[stapelberg, 2015-03-31 18:29:39]

The CQ bit was checked by stapelberg@google.com

[stapelberg, 2015-03-31 18:29:40]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1020263004/#ps20001
(title: "Force --enable-webkit-text-subpixel-positioning for DSF > 1.0.")

[commit-bot: I haz the power, 2015-03-31 18:29:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020263004/20001

[commit-bot: I haz the power, 2015-03-31 19:22:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-31 19:23:35]

Patchset 2 (id:??) landed as
https://crrev.com/442a5a6b163e6f9f7d798b5501c5143367e5c8c7
Cr-Commit-Position: refs/heads/master@{#323085}