pkg/compiler/lib/src/js_backend/codegen/glue.dart - Issue 1020243002: cps_ir: interceptor calling convention, operator== prologue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/glue.dart

Issue 1020243002: cps_ir: interceptor calling convention, operator== prologue (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/task.dart » ('j') | pkg/compiler/lib/src/js_backend/codegen/unsugar.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library code_generator_dependencies;	5 library code_generator_dependencies;

6	6

7 import '../js_backend.dart';	7 import '../js_backend.dart';

8 import '../../dart2jslib.dart';	8 import '../../dart2jslib.dart';

9 import '../../js_emitter/js_emitter.dart';	9 import '../../js_emitter/js_emitter.dart';

10 import '../../js/js.dart' as js;	10 import '../../js/js.dart' as js;

(...skipping 136 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
147	147

148 bool needsSubstitutionForTypeVariableAccess(ClassElement cls) {	148 bool needsSubstitutionForTypeVariableAccess(ClassElement cls) {

149 ClassWorld classWorld = _compiler.world;	149 ClassWorld classWorld = _compiler.world;

150 if (classWorld.isUsedAsMixin(cls)) return true;	150 if (classWorld.isUsedAsMixin(cls)) return true;

151	151

152 Iterable<ClassElement> subclasses = _compiler.world.strictSubclassesOf(cls);	152 Iterable<ClassElement> subclasses = _compiler.world.strictSubclassesOf(cls);

153 return subclasses.any((ClassElement subclass) {	153 return subclasses.any((ClassElement subclass) {

154 return !_backend.rti.isTrivialSubstitution(subclass, cls);	154 return !_backend.rti.isTrivialSubstitution(subclass, cls);

155 });	155 });

156 }	156 }

	157

	158 bool requiresEqNullCheck(FunctionElement element) {
	Kevin Millikin (Google) 2015/03/26 15:14:17 Can we avoid having two different names (requiresE Can we avoid having two different names (requiresEqNullCheck vs. !operatorEqHandlesNullArgument) for the same thing in two different places? If one is obviously better, we should just adopt it in both places.
	159 return !_backend.operatorEqHandlesNullArgument(element);

	160 }

157 }	161 }

OLD	NEW