Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp - Issue 1020233002: [bindings] [devtools] Migrate the usage of ScriptValue.toJSONValue() to ScriptValue::to<JSONValuePt…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 1020233002: [bindings] [devtools] Migrate the usage of ScriptValue.toJSONValue() to ScriptValue::to<JSONValuePt… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

index 8ea7fefeec70f34fab3df2327a6e7fd6bbb11f98..6dd5f15667baf87ab383977227a2aee3e4720efa 100644

--- a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -359,7 +359,7 @@ void V8InjectedScriptHost::inspectMethodCustom(const v8::FunctionCallbackInfo<v8

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

ScriptValue object(scriptState, info[0]);

ScriptValue hints(scriptState, info[1]);

- host->inspectImpl(object.toJSONValue(scriptState), hints.toJSONValue(scriptState));

+ host->inspectImpl(toJSONValue(object), toJSONValue(hints));

}

void V8InjectedScriptHost::evalMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/core/inspector/InjectedScript.cpp » ('j') | no next file with comments »