Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2435)

Side by Side Diff: Source/bindings/core/v8/ScriptValue.cpp

Issue 1020233002: [bindings] [devtools] Migrate the usage of ScriptValue.toJSONValue() to ScriptValue::to<JSONValuePt… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptValue.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 return false; 67 return false;
68 68
69 ScriptState::Scope scope(m_scriptState.get()); 69 ScriptState::Scope scope(m_scriptState.get());
70 v8::Handle<v8::Value> string = v8Value(); 70 v8::Handle<v8::Value> string = v8Value();
71 if (string.IsEmpty() || !string->IsString()) 71 if (string.IsEmpty() || !string->IsString())
72 return false; 72 return false;
73 result = toCoreString(v8::Handle<v8::String>::Cast(string)); 73 result = toCoreString(v8::Handle<v8::String>::Cast(string));
74 return true; 74 return true;
75 } 75 }
76 76
77 PassRefPtr<JSONValue> ScriptValue::toJSONValue(ScriptState* scriptState) const
78 {
79 ASSERT(scriptState->contextIsValid());
80 ScriptState::Scope scope(scriptState);
81 return v8ToJSONValue(scriptState->isolate(), v8Value(), JSONValue::maxDepth) ;
82 }
83
84 ScriptValue ScriptValue::createNull(ScriptState* scriptState) 77 ScriptValue ScriptValue::createNull(ScriptState* scriptState)
85 { 78 {
86 return ScriptValue(scriptState, v8::Null(scriptState->isolate())); 79 return ScriptValue(scriptState, v8::Null(scriptState->isolate()));
87 } 80 }
88 81
89 } // namespace blink 82 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptValue.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698