Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1020203002: Disable sharing of stencil buffers across differently sized rendertargets (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable sharing of stencil buffers across differently sized rendertargets Due to revertapalooza, stencil buffers shared across differently sized rendertargets aren't getting cleared correctly. This CL disables the sharing until the clearing issues can be remedied. Note that stencil buffers should still be shared between identically sized render targets and should still be lazily allocated. Committed: https://skia.googlesource.com/skia/+/ca75ea871e40cc4ebd19bfa26a096bec19fd464e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/gpu/GrGpu.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
5 years, 9 months ago (2015-03-20 13:24:21 UTC) #2
egdaniel
lgtm
5 years, 9 months ago (2015-03-20 13:33:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020203002/1
5 years, 9 months ago (2015-03-20 13:33:43 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 13:43:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ca75ea871e40cc4ebd19bfa26a096bec19fd464e

Powered by Google App Engine
This is Rietveld 408576698