Make AppListServiceAsh::OnProfileWillBeRemoved do nothing.

Make AppListServiceAsh::OnProfileWillBeRemoved do nothing.

This CL stops AppListServiceAsh handling an event it shouldn't care about,
preventing the AppListServiceViews on Linux handling it correctly.

BUG=469032
Committed: https://crrev.com/4b41ec18bbd6efa2439c546f1942a5a5a78fe6c5
Cr-Commit-Position: refs/heads/master@{#322322}

[calamity, 2015-03-23 03:42:18]

calamity@chromium.org changed reviewers:
+ tapted@chromium.org

[calamity, 2015-03-23 03:42:19]

Not sure if this is valid. Probably is...?

[tapted, 2015-03-24 18:21:07]

This lgtm to unblock things.

I think the underlying issue is that AppListServiceAsh shouldn't have the
ProfileStore data member that it picks up from AppListServiceImpl at all.

That's a bigger refactor... it would be easier if everything used
AppListServiceViews. And in fact, when Mac switches to having Views and Cocoa it
will need a different solution anyways, so I'll probably be poking this soon.

https://codereview.chromium.org/1020133002/diff/1/chrome/browser/ui/ash/app_l...
File chrome/browser/ui/ash/app_list/app_list_service_ash.h (right):

https://codereview.chromium.org/1020133002/diff/1/chrome/browser/ui/ash/app_l...
chrome/browser/ui/ash/app_list/app_list_service_ash.h:25: void
OnProfileWillBeRemoved(const base::FilePath& profile_path) override {}
nit: move implementation to .cc  (clang usually complains about this... maybe
just on Mac :/ ).

It should also have a comment. Something like:

  // On ChromeOS this should never happen. On other platforms, there is always a
  // Non-ash AppListService that is responsible for handling this.
  // TODO(..): Ash shouldn't observe the ProfileInfoCache at all.

[calamity, 2015-03-25 00:48:32]

Patchset #2 (id:20001) has been deleted

[calamity, 2015-03-25 02:07:25]

calamity@chromium.org changed reviewers:
+ jamescook@chromium.org

[calamity, 2015-03-25 02:07:25]

+jamescook for OWNERS.

[James Cook, 2015-03-25 15:28:02]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2015-03-25 15:28:03]

I'm not the right owner for this -- xiyuan, can you take a look?

(Also, have you guys considered extending the OWNERS file in
c/b/ui/ash/app_list?)

[xiyuan, 2015-03-25 16:21:40]

lgtm

[calamity, 2015-03-26 03:44:19]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-03-26 03:44:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1020133002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2015-03-26 03:45:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020133002/40001

[commit-bot: I haz the power, 2015-03-26 04:53:36]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-26 04:54:30]

Patchset 2 (id:??) landed as
https://crrev.com/4b41ec18bbd6efa2439c546f1942a5a5a78fe6c5
Cr-Commit-Position: refs/heads/master@{#322322}