Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1020113002: Fix initializing volume manager in Files app. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix initializing volume manager in Files app. Promise.all was called with a double array [[p1, p2]], instead of [p1, p2], which caused completing initialization of all volumes before they are added to the volume list, what caused failing tests in: crrev.com/985533004. TEST=Fixes test failures in crrev.com/985533004. BUG=None Committed: https://crrev.com/147fd75c0ad470da9109dcae72a269e80ecaef4e Cr-Commit-Position: refs/heads/master@{#321494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M ui/file_manager/file_manager/background/js/volume_manager.js View 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtomasz
@hirono: PTAL, thanks!
5 years, 9 months ago (2015-03-20 01:32:01 UTC) #2
mtomasz
@yawano: PTAL. Thanks!
5 years, 9 months ago (2015-03-20 01:32:22 UTC) #4
yawano
lgtm. Thank you!
5 years, 9 months ago (2015-03-20 01:39:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020113002/1
5 years, 9 months ago (2015-03-20 01:48:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 02:02:22 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 02:03:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/147fd75c0ad470da9109dcae72a269e80ecaef4e
Cr-Commit-Position: refs/heads/master@{#321494}

Powered by Google App Engine
This is Rietveld 408576698