Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1020103005: Preserve texture compression when saving a revised skp from debugger (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Preserve texture compression when saving a revised skp from debugger Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires. Committed: https://skia.googlesource.com/skia/+/3e5c2b1041b15641931638d1d78b30d3c435fc71

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make a shared utility #

Patch Set 3 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M gm/colorwheel.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M gm/displacement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 3 chunks +2 lines, -13 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 3 chunks +2 lines, -14 lines 0 comments Download
M tools/sk_tool_utils.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
5 years, 9 months ago (2015-03-20 17:15:55 UTC) #2
scroggo
lgtm with or without consolidating https://codereview.chromium.org/1020103005/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/1020103005/diff/1/debugger/QT/SkDebuggerGUI.cpp#newcode360 debugger/QT/SkDebuggerGUI.cpp:360: class PngPixelSerializer : public ...
5 years, 9 months ago (2015-03-20 17:21:42 UTC) #3
robertphillips
ptal - this patch consolidates the 3 pixel serializers
5 years, 9 months ago (2015-03-20 19:24:28 UTC) #4
scroggo
LGTM Thanks!
5 years, 9 months ago (2015-03-20 19:30:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020103005/40001
5 years, 9 months ago (2015-03-20 19:33:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020103005/40001
5 years, 9 months ago (2015-03-23 12:41:02 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 12:47:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3e5c2b1041b15641931638d1d78b30d3c435fc71

Powered by Google App Engine
This is Rietveld 408576698