Issue 1020103004: [Effen] minor cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1020103004: [Effen] minor cleanup (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] minor cleanup This patch adds an assert that the mount/unmount queues are not subject to concurrent modification and refactors the sync-tracing to avoid the cost of string interpolation if tracing is disabled. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6cd319fbd5d63fe3c21c5e0c04d19be5d7f68d8a

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -14 lines)			Patch
	M	sky/framework/fn.dart	View	1	8 chunks	+44 lines, -14 lines	0 comments	Download

Total messages: 5 (1 generated)

rafaelw

5 years, 9 months ago (2015-03-20 17:20:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6cd319fbd5d63fe3c21c5e0c04d19be5d7f68d8a (presubmit successful).