Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1020083002: Don't show import buttons when import is disabled, and use correct icons for insufficient space sta… (Closed)

Created:
5 years, 9 months ago by Steve McKay
Modified:
5 years, 9 months ago
Reviewers:
Ben Kwa
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show import buttons when import is disabled, and use correct icons for insufficient space state (were inverted). BUG=468971 TEST=manual Committed: https://crrev.com/7547b20c9a1a39f5cdf9f44dd0a60b18abd00e94 Cr-Commit-Position: refs/heads/master@{#321473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/import_controller.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Steve McKay
5 years, 9 months ago (2015-03-19 23:27:41 UTC) #2
Steve McKay
Feel free to hit the commit box.
5 years, 9 months ago (2015-03-19 23:28:08 UTC) #3
Ben Kwa
lgtm
5 years, 9 months ago (2015-03-19 23:29:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020083002/1
5 years, 9 months ago (2015-03-19 23:29:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 00:02:05 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 00:02:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7547b20c9a1a39f5cdf9f44dd0a60b18abd00e94
Cr-Commit-Position: refs/heads/master@{#321473}

Powered by Google App Engine
This is Rietveld 408576698