Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1020053002: Remove pauseAnimationsForTesting (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove pauseAnimationsForTesting This code is unused and it hooks into the DocumentLifecycle in sketchy ways. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e269ca489d69a3d8d4a7235838fc33306f3a3937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -49 lines) Patch
M sky/engine/core/animation/AnimationTimeline.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationTimeline.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/animation/AnimationTimelineTest.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/page/PageAnimator.cpp View 1 chunk +3 lines, -10 lines 0 comments Download
M sky/engine/public/web/WebDocument.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebDocument.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/viewer/internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/internals.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-19 23:09:44 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-20 02:22:50 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-20 02:32:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e269ca489d69a3d8d4a7235838fc33306f3a3937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698