Replace dart_core.js with actual compiled SDK

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap;
 import 'dart:io' show Directory, File;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
@@ skipping 13 matching lines @@
 import 'package:dev_compiler/src/js/js_ast.dart' as JS;
 import 'package:dev_compiler/src/js/js_ast.dart' show js;
 
 import 'package:dev_compiler/src/checker/rules.dart';
 import 'package:dev_compiler/src/info.dart';
 import 'package:dev_compiler/src/options.dart';
 import 'package:dev_compiler/src/report.dart';
 import 'package:dev_compiler/src/utils.dart';
 import 'code_generator.dart';
 
-// This must match the optional parameter name used in runtime.js
-const String _jsNamedParameterName = r'opt$';
-
 bool _isAnnotationType(Annotation m, String name) => m.name.name == name;
 
 Annotation _getAnnotation(AnnotatedNode node, String name) => node.metadata
     .firstWhere((annotation) => _isAnnotationType(annotation, name),
         orElse: () => null);
 
 Annotation _getJsNameAnnotation(AnnotatedNode node) =>
     _getAnnotation(node, "JsName");
 
 class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
@@ skipping 76 matching lines @@
 
     var defaultValue = js.call(jsDefaultValue);
     return new JS.Program([
       js.statement('var #;', name),
       js.statement("(function($_EXPORTS) { 'use strict'; #; })(# || (# = #));",
           [body, name, name, defaultValue])
     ]);
   }
 
   JS.Statement _initPrivateSymbol(String name) =>
-      js.statement('let # = Symbol(#);', [name, js.string(name, "'")]);
+      js.statement('let # = $_SYMBOL(#);', [name, js.string(name, "'")]);
+
+  // TODO(jmesserly): this is a temporary workaround for `Symbol` in core,
+  // until we have better name tracking.
+  String get _SYMBOL => currentLibrary.isDartCore ? 'dart.JsSymbol' : 'Symbol';
 
   @override
   JS.Statement visitCompilationUnit(CompilationUnit node) {
     var source = node.element.source;
 
     _constEvaluator = new ConstantEvaluator(source, rules.provider);
     _checkerReporter.enterSource(source);
 
     // TODO(jmesserly): scriptTag, directives.
     var body = <JS.Statement>[];
@@ skipping 108 matching lines @@
   JS.Statement visitClassTypeAlias(ClassTypeAlias node) {
     // If we've already emitted this class, skip it.
     var classElem = node.element;
     if (_pendingClasses.remove(classElem) == null) return null;
 
     var name = node.name.name;
     var heritage =
         js.call('dart.mixin(#)', [_visitList(node.withClause.mixinTypes)]);
     var classDecl = new JS.ClassDeclaration(
         new JS.ClassExpression(new JS.VariableDeclaration(name), heritage, []));
-    if (isPublic(name)) _exports.add(name);
 
     return _finishClassDef(classElem, classDecl);
   }
 
   @override
   JS.Statement visitClassDeclaration(ClassDeclaration node) {
     // If we've already emitted this class, skip it.
     var classElem = node.element;
     if (_pendingClasses.remove(classElem) == null) return null;
     if (_getJsNameAnnotation(node) != null) return null;
 
     currentClass = node;
 
     var name = classElem.name;
-    if (isPublic(name)) _exports.add(name);
 
     var ctors = <ConstructorDeclaration>[];
     var fields = <FieldDeclaration>[];
     var staticFields = <FieldDeclaration>[];
     for (var member in node.members) {
       if (member is ConstructorDeclaration) {
         ctors.add(member);
       } else if (member is FieldDeclaration) {
         (member.isStatic ? staticFields : fields).add(member);
       }
@@ skipping 46 matching lines @@
 
       return js.statement(
           'dart.defineLazyClass(#, { get #() { #; return #; } });', [
         _EXPORTS,
         name,
         body,
         name
       ]);
     }
 
+    if (isPublic(name)) _exports.add(name);
+
     if (genericDef != null) {
       body = js.statement('{ #; let # = #; }', [genericDef, name, genericInst]);
+      if (isPublic(name)) _exports.add(genericName);
     }
 
     if (classElem.type.isObject) return body;
 
     // If we're not lazy, we still need to ensure our dependencies are
     // generated first.
     var classDefs = <JS.Statement>[];
     _emitClassIfNeeded(classDefs, classElem.supertype.element);
     for (var m in classElem.mixins) {
       _emitClassIfNeeded(classDefs, m.element);
@@ skipping 94 matching lines @@
       if (result) break;
       result = _inLibraryCycle(e.exportedLibrary);
     }
     return _libraryCycleMemo[library] = result;
   }
 
   JS.Statement _emitGenericClassDef(ClassElement cls, JS.Statement body) {
     var name = cls.name;
     var genericName = '$name\$';
     var typeParams = cls.typeParameters.map((p) => new JS.Parameter(p.name));
-    // TODO(jmesserly): is it worth exporting both names? Alternatively we could
-    // put the generic type constructor on the <dynamic> instance.
-    if (isPublic(name)) _exports.add(genericName);
     return js.statement('let # = dart.generic(function(#) { #; return #; });', [
       genericName,
       typeParams,
       body,
       name
     ]);
   }
 
   JS.Expression _classHeritage(ClassDeclaration node) {
     if (node.element.type.isObject) return null;
@@ skipping 41 matching lines @@
     if (element.library.isDartCore && element.name == 'Iterable') {
       JS.Fun body = js.call('''function() {
         var iterator = this.iterator;
         return {
           next() {
             var done = iterator.moveNext();
             return { done: done, current: done ? void 0 : iterator.current };
           }
         };
       }''');
-      jsMethods.add(new JS.Method(js.call('Symbol.iterator'), body));
+      jsMethods.add(new JS.Method(js.call('$_SYMBOL.iterator'), body));
     }
     return jsMethods.where((m) => m != null).toList(growable: false);
   }
 
   /// Emit class members that need to come after the class declaration, such
   /// as static fields. See [_emitClassMethods] for things that are emitted
   /// insite the ES6 `class { ... }` node.
   JS.Statement _finishClassMembers(String name, JS.ClassExpression cls,
       List<ConstructorDeclaration> ctors, List<FieldDeclaration> staticFields) {
     var body = <JS.Statement>[];
@@ skipping 56 matching lines @@
         node.name == null) {
       // Implements Dart constructor behavior. Because of V8 `super`
       // [constructor restrictions]
       // (https://code.google.com/p/v8/issues/detail?id=3330#c65)
       // we cannot currently emit actual ES6 constructors with super calls.
       // Instead we use the same trick as named constructors, and do them as
       // instance methods that perform initialization.
       // TODO(jmesserly): we'll need to rethink this once the ES6 spec and V8
       // settles. See <https://github.com/dart-lang/dev_compiler/issues/51>.
       // Performance of this pattern is likely to be bad.
+      name = 'constructor';
       body = js.statement('''{
         // Get the class name for this instance.
         var name = this.constructor.name;
         // Call the default constructor.
         var init = this[name];
         var result = void 0;
         if (init) result = init.apply(this, arguments);
         return result === void 0 ? this : result;
       }''');
     } else {
@@ skipping 179 matching lines @@
     if (parameters == null || !_hasArgumentInitializers(parameters)) {
       return null;
     }
 
     var body = [];
     for (var param in parameters.parameters) {
       // TODO(justinfagnani): rename identifier if necessary
       var name = param.identifier.name;
 
       if (param.kind == ParameterKind.NAMED) {
-        body.add(js.statement('let # = opt\$.# === void 0 ? # : opt\$.#;', [
+        body.add(js.statement('let # = opt\$ && # in opt\$ ? opt\$.# : #;', [
           name,
+          js.string(name, "'"),
           name,
           _defaultParamValue(param),
-          name
         ]));
       } else if (param.kind == ParameterKind.POSITIONAL) {
         body.add(js.statement('if (# === void 0) # = #;', [
           name,
           name,
           _defaultParamValue(param)
         ]));
       }
     }
     return _statement(body);
@@ skipping 43 matching lines @@
 
     body.add(new JS.FunctionDeclaration(
         new JS.VariableDeclaration(name), _visit(node.functionExpression)));
 
     if (isPublic(name)) _exports.add(name);
     return _statement(body);
   }
 
   JS.Method _emitTopLevelProperty(FunctionDeclaration node) {
     var name = node.name.name;
-    if (isPublic(name)) _exports.add(name);
     return new JS.Method(
         new JS.PropertyName(name), _visit(node.functionExpression),
         isGetter: node.isGetter, isSetter: node.isSetter);
   }
 
   @override
   JS.Expression visitFunctionExpression(FunctionExpression node) {
     var params = _visit(node.parameters);
     if (params == null) params = [];
 
@@ skipping 274 matching lines @@
     assert(node.parent is ArgumentList);
     return new JS.Property(
         new JS.PropertyName(node.name.label.name), _visit(node.expression));
   }
 
   @override
   List<JS.Parameter> visitFormalParameterList(FormalParameterList node) {
     var result = <JS.Parameter>[];
     for (FormalParameter param in node.parameters) {
       if (param.kind == ParameterKind.NAMED) {
-        result.add(new JS.Parameter(_jsNamedParameterName));
+        result.add(new JS.Parameter(r'opt$'));
         break;
       }
       result.add(_visit(param));
     }
     return result;
   }
 
   @override
   JS.Statement visitExpressionStatement(ExpressionStatement node) =>
       _expressionStatement(_visit(node.expression));
@@ skipping 1127 matching lines @@
 
     // TODO(jmesserly): in many cases marking the end will be unncessary.
     printer.mark(_location(node.end));
   }
 
   String _getIdentifier(AstNode node) {
     if (node is SimpleIdentifier) return node.name;
     return null;
   }
 }