Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1020043002: Replace dart_core.js with actual compiled SDK (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace dart_core.js with actual compiled SDK Almost no calls are going to work at this point, but core.js can load now and there is enough in place to continue to load sunflower. R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/717ca26e4f883a2b7ea9a2e5e821347f8ac9b976

Patch Set 1 : #

Total comments: 5

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -28715 lines) Patch
A + lib/runtime/dart/_foreign_helper.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/runtime/dart/_interceptors.js View 1 4 chunks +5 lines, -6 lines 0 comments Download
A + lib/runtime/dart/_internal.js View 1 6 chunks +8 lines, -8 lines 0 comments Download
A + lib/runtime/dart/_isolate_helper.js View 1 4 chunks +5 lines, -8 lines 0 comments Download
A + lib/runtime/dart/_js_embedded_names.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/runtime/dart/_js_helper.js View 1 6 chunks +5 lines, -8 lines 0 comments Download
A + lib/runtime/dart/_js_names.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/runtime/dart/_js_primitives.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/runtime/dart/_native_typed_data.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/runtime/dart/async.js View 1 31 chunks +85 lines, -85 lines 0 comments Download
A + lib/runtime/dart/collection.js View 1 21 chunks +33 lines, -35 lines 0 comments Download
A + lib/runtime/dart/convert.js View 1 13 chunks +14 lines, -14 lines 0 comments Download
A + lib/runtime/dart/core.js View 1 34 chunks +134 lines, -149 lines 0 comments Download
A + lib/runtime/dart/isolate.js View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + lib/runtime/dart/math.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/runtime/dart/typed_data.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M lib/runtime/dart_runtime.js View 1 3 chunks +11 lines, -8 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 11 chunks +13 lines, -14 lines 0 comments Download
M lib/src/dependency_graph.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/options.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/utils.dart View 1 1 chunk +11 lines, -7 lines 0 comments Download
M test/codegen/expect/constructors.js View 1 1 chunk +1 line, -1 line 0 comments Download
D test/codegen/expect/dart/_foreign_helper.js View 1 1 chunk +0 lines, -156 lines 0 comments Download
D test/codegen/expect/dart/_interceptors.js View 1 1 chunk +0 lines, -1419 lines 0 comments Download
D test/codegen/expect/dart/_internal.js View 1 1 chunk +0 lines, -1893 lines 0 comments Download
D test/codegen/expect/dart/_isolate_helper.js View 1 1 chunk +0 lines, -1313 lines 0 comments Download
D test/codegen/expect/dart/_js_embedded_names.js View 1 1 chunk +0 lines, -67 lines 0 comments Download
D test/codegen/expect/dart/_js_helper.js View 1 1 chunk +0 lines, -3962 lines 0 comments Download
D test/codegen/expect/dart/_js_names.js View 1 1 chunk +0 lines, -79 lines 0 comments Download
D test/codegen/expect/dart/_js_primitives.js View 1 1 chunk +0 lines, -25 lines 0 comments Download
D test/codegen/expect/dart/_native_typed_data.js View 1 1 chunk +0 lines, -1538 lines 0 comments Download
D test/codegen/expect/dart/async.js View 1 1 chunk +0 lines, -4952 lines 0 comments Download
D test/codegen/expect/dart/collection.js View 1 1 chunk +0 lines, -4899 lines 0 comments Download
D test/codegen/expect/dart/convert.js View 1 1 chunk +0 lines, -2330 lines 0 comments Download
D test/codegen/expect/dart/core.js View 1 1 chunk +0 lines, -3056 lines 0 comments Download
D test/codegen/expect/dart/isolate.js View 1 1 chunk +0 lines, -211 lines 0 comments Download
D test/codegen/expect/dart/math.js View 1 1 chunk +0 lines, -452 lines 0 comments Download
D test/codegen/expect/dart/typed_data.js View 1 1 chunk +0 lines, -872 lines 0 comments Download
M test/codegen/expect/fieldtest.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen/expect/methods.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/codegen/expect/sunflower/dom.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen_test.dart View 1 5 chunks +41 lines, -46 lines 0 comments Download
M test/dependency_graph_test.dart View 1 23 chunks +31 lines, -74 lines 0 comments Download
M test/generated_sdk/lib/core/core.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/function.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/core/int.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/list.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/test.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tool/build_sdk.sh View 1 1 chunk +23 lines, -0 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_html.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_html_common.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_indexed_db.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_io.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_js.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_svg.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_web_audio.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_web_gl.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/dart_web_sql.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/core_stubs/metadata.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/serialize.dart View 1 1 chunk +0 lines, -184 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/serialize/aggregate_transform.dart View 1 1 chunk +0 lines, -173 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/serialize/exception.dart View 1 1 chunk +0 lines, -102 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/serialize/get_input_transform.dart View 1 1 chunk +0 lines, -34 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/serialize/transform.dart View 1 1 chunk +0 lines, -149 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/serialize/transformer.dart View 1 1 chunk +0 lines, -126 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart View 1 1 chunk +0 lines, -112 lines 0 comments Download
D tool/input_sdk/lib/_internal/pub/asset/dart/utils.dart View 1 1 chunk +0 lines, -86 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 1 5 chunks +12 lines, -4 lines 0 comments Download
M tool/patch_sdk.dart View 1 6 chunks +50 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/1020043002/diff/10001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1020043002/diff/10001/lib/runtime/dart_runtime.js#newcode306 lib/runtime/dart_runtime.js:306: if (arguments.length != length && arguments.length != 0) { ...
5 years, 9 months ago (2015-03-19 22:57:34 UTC) #3
Siggi Cherem (dart-lang)
very nice! This is really exciting! https://codereview.chromium.org/1020043002/diff/10001/lib/src/utils.dart File lib/src/utils.dart (right): https://codereview.chromium.org/1020043002/diff/10001/lib/src/utils.dart#newcode323 lib/src/utils.dart:323: if (_packageNameWithVersion.stringMatch(s) == ...
5 years, 9 months ago (2015-03-19 23:11:14 UTC) #4
Siggi Cherem (dart-lang)
(lgtm)
5 years, 9 months ago (2015-03-19 23:11:28 UTC) #5
Jennifer Messerly
thanks! merged ... the only change is: https://codereview.chromium.org/1020043002/diff/20001/lib/src/utils.dart if you want to take a look ...
5 years, 9 months ago (2015-03-20 16:36:46 UTC) #6
Siggi Cherem (dart-lang)
lgtm
5 years, 9 months ago (2015-03-20 16:40:50 UTC) #7
Jennifer Messerly
5 years, 9 months ago (2015-03-20 16:41:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
717ca26e4f883a2b7ea9a2e5e821347f8ac9b976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698