Make pause-on-exceptions toggle/tri-state button.

Source/devtools/front_end/StatusBarButton.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 83 matching lines @@
  * @constructor
  * @extends {WebInspector.StatusBarItem}
  * @param {string} title
  * @param {string} className
  * @param {number=} states
  */
 WebInspector.StatusBarButton = function(title, className, states)
 {
     WebInspector.StatusBarItem.call(this, document.createElement("button"));
     this.element.className = className + " status-bar-item";
-    this.element.addEventListener("click", this._clicked.bind(this), false);
+    this.element.addEventListener("click", this._clicked.bind(this, false), false);
 
     this.glyph = document.createElement("div");
     this.glyph.className = "glyph";
     this.element.appendChild(this.glyph);
 
     this.glyphShadow = document.createElement("div");
     this.glyphShadow.className = "glyph shadow";
     this.element.appendChild(this.glyphShadow);
 
     this.states = states;
     if (!states)
         this.states = 2;
 
     if (states == 2)
         this._state = false;
     else
         this._state = 0;
 
     this.title = title;
     this.className = className;
     this._visible = true;
 }
 
 WebInspector.StatusBarButton.prototype = {
-    _clicked: function()
+    /**
+     * @param {boolean} fromLongClick
+     */
+    _clicked: function(fromLongClick)
     {
-        this.dispatchEventToListeners("click");
+        this.dispatchEventToListeners("click", fromLongClick);
         if (this._longClickInterval) {
             clearInterval(this._longClickInterval);
             delete this._longClickInterval;
         }
     },
 
     /**
      * @override
      */
     _applyEnabledState: function()
@@ skipping 170 matching lines @@
             delete this._longClickOptionsData;
 
             this.unmakeLongClickEnabled();
         }
     },
 
     _showOptions: function()
     {
         var buttons = this._longClickOptionsData.buttonsProvider();
         var mainButtonClone = new WebInspector.StatusBarButton(this.title, this.className, this.states);
-        mainButtonClone.addEventListener("click", this._clicked, this);
+        mainButtonClone.addEventListener("click", this._clicked.bind(this, true), this);
         mainButtonClone.state = this.state;
-        buttons.push(mainButtonClone);
+        buttons.unshift(mainButtonClone);

[aandrey, 2013/12/23 09:04:10]

if it is a refactoring that has nothing to do with the bug, can we move it to a
separate patch?

[eustas, 2013/12/26 07:35:37]

It is essential. Without this change order of "additional" buttons will change
to reverse.

This wasn't a problem because all previous usages have 1 option.
Now there are 2 options and order matters.

 
         var mouseUpListener = mouseUp.bind(this);
         document.documentElement.addEventListener("mouseup", mouseUpListener, false);
 
         var optionsGlassPane = new WebInspector.GlassPane();
         var optionsBarElement = optionsGlassPane.element.createChild("div", "alternate-status-bar-buttons-bar");
         const buttonHeight = 23;
 
         var hostButtonPosition = this.element.totalOffset();
 
         var topNotBottom = hostButtonPosition.top + buttonHeight * buttons.length < document.documentElement.offsetHeight;
 
-        if (topNotBottom)
+        if (!topNotBottom)
             buttons = buttons.reverse();
 
         optionsBarElement.style.height = (buttonHeight * buttons.length) + "px";
         if (topNotBottom)
             optionsBarElement.style.top = (hostButtonPosition.top + 1) + "px";
         else
             optionsBarElement.style.top = (hostButtonPosition.top - (buttonHeight * (buttons.length - 1))) + "px";
         optionsBarElement.style.left = (hostButtonPosition.left + 1) + "px";
 
         var boundMouseOver = mouseOver.bind(this);
@@ skipping 25 matching lines @@
         function mouseUp(e)
         {
             if (e.which !== 1)
                 return;
             optionsGlassPane.dispose();
             document.documentElement.removeEventListener("mouseup", mouseUpListener, false);
 
             for (var i = 0; i < buttons.length; ++i) {
                 if (buttons[i].element.classList.contains("emulate-active")) {
                     buttons[i].element.classList.remove("emulate-active");
-                    buttons[i]._clicked();
+                    buttons[i]._clicked(true);
                     break;
                 }
             }
         }
     },
 
     __proto__: WebInspector.StatusBarItem.prototype
 }
 
 /**
@@ skipping 133 matching lines @@
     /**
      * @return {boolean}
      */
     checked: function()
     {
         return this._checkbox.checked;
     },
 
     __proto__: WebInspector.StatusBarItem.prototype
 }