Make pause-on-exceptions toggle/tri-state button.

Make pause-on-exceptions toggle/tri-state button.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165051

[aandrey, 2013-12-23 09:04:09]

screenshot?

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
File Source/devtools/front_end/SourcesPanel.js (right):

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:218:
WebInspector.SourcesPanel.PauseOnExceptionsStates = [
We will need to keep it in sync with the
WebInspector.DebuggerModel.PauseOnExceptionsState.
Let's use WebInspector.DebuggerModel.PauseOnExceptionsState.values() instead,
and put a comment that the key order affects UI.

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:730: _createPauseOnExceptionOptions:
function()
@return jsdoc missing

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:734: var pauseStates =
WebInspector.SourcesPanel.PauseOnExceptionsStates.slice(0);
var pauseStates = WebInspector.DebuggerModel.PauseOnExceptionsState.values();

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:754: * @param
{!WebInspector.DebuggerModel.PauseOnExceptionsState} state
@return missing

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:766: throw("Unexpected 
PauseOnExceptionsState: " + state);
2 spaces -> 1

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:810: var state = e.target.state;
@type cast?

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/St...
File Source/devtools/front_end/StatusBarButton.js (right):

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/St...
Source/devtools/front_end/StatusBarButton.js:327:
buttons.unshift(mainButtonClone);
if it is a refactoring that has nothing to do with the bug, can we move it to a
separate patch?

[eustas, 2013-12-26 07:35:36]

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
File Source/devtools/front_end/SourcesPanel.js (right):

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:218:
WebInspector.SourcesPanel.PauseOnExceptionsStates = [
On 2013/12/23 09:04:10, aandrey wrote:
> We will need to keep it in sync with the
> WebInspector.DebuggerModel.PauseOnExceptionsState.
> Let's use WebInspector.DebuggerModel.PauseOnExceptionsState.values() instead,
> and put a comment that the key order affects UI.

Order shouldn't change, even if enum changes - this will break UX.
When changes are incompatible, JS compiler will notify developer.
Otherwise UI should remain untouched until developer decides how to change it.

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:730: _createPauseOnExceptionOptions:
function()
On 2013/12/23 09:04:10, aandrey wrote:
> @return jsdoc missing

Done.

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:754: * @param
{!WebInspector.DebuggerModel.PauseOnExceptionsState} state
On 2013/12/23 09:04:10, aandrey wrote:
> @return missing

Done.

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:766: throw("Unexpected 
PauseOnExceptionsState: " + state);
On 2013/12/23 09:04:10, aandrey wrote:
> 2 spaces -> 1

Done.

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:810: var state = e.target.state;
On 2013/12/23 09:04:10, aandrey wrote:
> @type cast?

Done.

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/St...
File Source/devtools/front_end/StatusBarButton.js (right):

https://codereview.chromium.org/102003006/diff/1/Source/devtools/front_end/St...
Source/devtools/front_end/StatusBarButton.js:327:
buttons.unshift(mainButtonClone);
On 2013/12/23 09:04:10, aandrey wrote:
> if it is a refactoring that has nothing to do with the bug, can we move it to
a
> separate patch?

It is essential. Without this change order of "additional" buttons will change
to reverse.

This wasn't a problem because all previous usages have 1 option.
Now there are 2 options and order matters.

[vsevik, 2013-12-27 09:22:33]

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
File Source/devtools/front_end/DebuggerModel.js (right):

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/DebuggerModel.js:52:
WebInspector.settings.lastPauseOnExceptionState =
WebInspector.settings.createSetting("lastPauseOnExceptionState",
WebInspector.DebuggerModel.PauseOnExceptionsState.PauseOnAllExceptions);
PauseOnUncaught by default is better.

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
File Source/devtools/front_end/SourcesPanel.js (right):

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/SourcesPanel.js:220:
WebInspector.DebuggerModel.PauseOnExceptionsState.PauseOnAllExceptions,
012 -> 021

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/SourcesPanel.js:736: var options =
this._pauseOnExceptionButtons.slice(1);
Let's create buttons here instead.

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/SourcesPanel.js:818: if (toggle) {
We should make different titles for each possible behavior after click.
I would expect that we have 3 titles like (<Current state>. Click to <Toggle
state>)
and 3 titles like (<Long click state>)

[eustas, 2013-12-30 14:08:59]

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
File Source/devtools/front_end/DebuggerModel.js (right):

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/DebuggerModel.js:52:
WebInspector.settings.lastPauseOnExceptionState =
WebInspector.settings.createSetting("lastPauseOnExceptionState",
WebInspector.DebuggerModel.PauseOnExceptionsState.PauseOnAllExceptions);
On 2013/12/27 09:22:34, vsevik wrote:
> PauseOnUncaught by default is better.

Done.

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
File Source/devtools/front_end/SourcesPanel.js (right):

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/SourcesPanel.js:220:
WebInspector.DebuggerModel.PauseOnExceptionsState.PauseOnAllExceptions,
On 2013/12/27 09:22:34, vsevik wrote:
> 012 -> 021

Done.

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/SourcesPanel.js:736: var options =
this._pauseOnExceptionButtons.slice(1);
On 2013/12/27 09:22:34, vsevik wrote:
> Let's create buttons here instead.

Done.

https://chromiumcodereview.appspot.com/102003006/diff/70001/Source/devtools/f...
Source/devtools/front_end/SourcesPanel.js:818: if (toggle) {
On 2013/12/27 09:22:34, vsevik wrote:
> We should make different titles for each possible behavior after click.
> I would expect that we have 3 titles like (<Current state>. Click to <Toggle
> state>)
> and 3 titles like (<Long click state>)

Done.

[eustas, 2014-01-10 10:37:18]

Ping

[vsevik, 2014-01-13 09:20:19]

lgtm unless pfeldman@ dislikes new UX.

https://codereview.chromium.org/102003006/diff/180001/Source/devtools/front_e...
File Source/devtools/front_end/StatusBarButton.js (right):

https://codereview.chromium.org/102003006/diff/180001/Source/devtools/front_e...
Source/devtools/front_end/StatusBarButton.js:130: * @param {boolean}
fromLongClick
optionClick

[eustas, 2014-01-13 10:17:02]

https://codereview.chromium.org/102003006/diff/180001/Source/devtools/front_e...
File Source/devtools/front_end/StatusBarButton.js (right):

https://codereview.chromium.org/102003006/diff/180001/Source/devtools/front_e...
Source/devtools/front_end/StatusBarButton.js:130: * @param {boolean}
fromLongClick
On 2014/01/13 09:20:20, vsevik wrote:
> optionClick

Done.

[commit-bot: I haz the power, 2014-01-14 07:35:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eustas@chromium.org/102003006/230001

[commit-bot: I haz the power, 2014-01-14 09:34:20]

Change committed as 165051

[eustas, 2014-01-27 18:00:36]

A revert of this CL has been created in
https://codereview.chromium.org/145583007/ by eustas@chromium.org.

The reason for reverting is: Temporarily revert to avoid user confusion..