Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 102003004: [DevTools] Do not filter manually entered commands in console. (Closed)

Created:
7 years ago by Dmitry Zvorygin
Modified:
7 years ago
Reviewers:
vsevik, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[DevTools] Do not filter manually entered commands in console. BUG=324595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163328

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed blank lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -1 line) Patch
A LayoutTests/inspector/console/console-filter-level-test.html View 1 1 chunk +103 lines, -0 lines 0 comments Download
A LayoutTests/inspector/console/console-filter-level-test-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ConsoleModel.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Zvorygin
Please take a look.
7 years ago (2013-12-05 15:50:10 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/102003004/diff/1/LayoutTests/inspector/console/console-filter-level-test.html File LayoutTests/inspector/console/console-filter-level-test.html (right): https://chromiumcodereview.appspot.com/102003004/diff/1/LayoutTests/inspector/console/console-filter-level-test.html#newcode22 LayoutTests/inspector/console/console-filter-level-test.html:22: nit: extra line https://chromiumcodereview.appspot.com/102003004/diff/1/LayoutTests/inspector/console/console-filter-level-test.html#newcode44 LayoutTests/inspector/console/console-filter-level-test.html:44: }, nit: blank ...
7 years ago (2013-12-06 08:48:44 UTC) #2
Dmitry Zvorygin
Fixed blank lines. https://codereview.chromium.org/102003004/diff/1/LayoutTests/inspector/console/console-filter-level-test.html File LayoutTests/inspector/console/console-filter-level-test.html (right): https://codereview.chromium.org/102003004/diff/1/LayoutTests/inspector/console/console-filter-level-test.html#newcode22 LayoutTests/inspector/console/console-filter-level-test.html:22: On 2013/12/06 08:48:44, vsevik wrote: > ...
7 years ago (2013-12-06 10:02:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/102003004/20001
7 years ago (2013-12-06 10:03:38 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-06 13:14:12 UTC) #5
Message was sent while issue was closed.
Change committed as 163328

Powered by Google App Engine
This is Rietveld 408576698