Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 102003002: Remove TextTrackCue::isVTTCue (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, nessy, philipj_slow, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove TextTrackCue::isVTTCue It is unused, as virtual functions are used instead of casting. BUG=270340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/html/track/TextTrackCue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
7 years ago (2013-12-03 14:41:22 UTC) #1
gasubic
On 2013/12/03 14:41:22, philipj wrote: this will have to be reverted when DataCue is implemented
7 years ago (2013-12-03 16:00:52 UTC) #2
adamk
lgtm Seems fine to delete this for now if there are no callers, easy enough ...
7 years ago (2013-12-03 18:53:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/102003002/1
7 years ago (2013-12-03 18:54:08 UTC) #4
acolwell GONE FROM CHROMIUM
lgtm. I'd rather remove the unused code for now and simply add it back as ...
7 years ago (2013-12-03 18:54:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/102003002/1
7 years ago (2013-12-03 21:01:37 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 21:31:07 UTC) #7
Message was sent while issue was closed.
Change committed as 163113

Powered by Google App Engine
This is Rietveld 408576698