Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1020023002: Treat standalone default/initial/inherit in font-family as invalid (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Treat standalone default/initial/inherit in font-family as invalid Treat standalone default/initial/inherit in font-family as invalid in the case where it is not a substring of a family name and it is at the end of the current family name (next token is comma or end of value list). Test is adapted according to this new behavior. Behavior matches FireFox. BUG=389148 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M LayoutTests/fast/css/font-family-parse-keyword.html View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/font-family-parse-keyword-expected.html View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-20 01:51:06 UTC) #2
Timothy Loh
lgtm
5 years, 9 months ago (2015-03-20 02:14:16 UTC) #3
Timothy Loh
On 2015/03/20 02:14:16, Timothy Loh wrote: > lgtm Although maybe worthwhile to add tests with ...
5 years, 9 months ago (2015-03-20 02:14:36 UTC) #4
rwlbuis
On 2015/03/20 02:14:36, Timothy Loh wrote: > On 2015/03/20 02:14:16, Timothy Loh wrote: > > ...
5 years, 9 months ago (2015-03-20 13:11:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020023002/1
5 years, 9 months ago (2015-03-20 13:11:56 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 15:11:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192254

Powered by Google App Engine
This is Rietveld 408576698