Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1019973003: Call _notifyMountStatusChanged() on App startup (Closed)

Created:
5 years, 9 months ago by hansmuller
Modified:
5 years, 9 months ago
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Call _notifyMountStatusChanged() on App startup A recent change caused my scrolling app to fail because didMount() was no longer called on my Scrollable subclass at startup time. I haven't been able to sort out how this used to work. This CL is a hack to make it work again. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4203cd8dabc4c5729e9601451d4e18faa72cc903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sky/framework/fn.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hansmuller1
PTAL
5 years, 9 months ago (2015-03-19 20:47:40 UTC) #3
rafaelw
Lgtm. Thanks. Sorry for the breakage.
5 years, 9 months ago (2015-03-19 21:04:44 UTC) #4
hansmuller
5 years, 9 months ago (2015-03-19 21:05:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4203cd8dabc4c5729e9601451d4e18faa72cc903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698