Check for NULL PasswordFormManager* in ManagePasswordsUIController::SavePasswordInternal().

chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index cba75401d0cda884cf6daacb29abf59e68e60791..8090880b8aacf1a3e85b7d523d3f54fd4c4c4380 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -218,8 +218,11 @@ void ManagePasswordsUIController::ChooseCredential(
 void ManagePasswordsUIController::SavePasswordInternal() {
   password_manager::PasswordFormManager* form_manager =
       passwords_data_.form_manager();
-  DCHECK(form_manager);
-  form_manager->Save();
+  // TODO(vasilii): it's not OK to call SavePassword() when |form_manager| is 0.
+  // If this is a cause of crbug/468474 then we should hide the bubble when

[vabr (Chromium), 2015/03/19 18:19:10]

nit: crbug/468474 -> http://crbug.com/468474
(For convenience when clicking through the link in CodeSearch.)

[vasilii, 2015/03/19 18:23:11]

Done.

+  // ManagePasswordsUIController changes its internal state.
+  if (form_manager)
+    form_manager->Save();
 }
 
 void ManagePasswordsUIController::NeverSavePassword() {