pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart - Issue 1019923005: Dart2js deferred loading. Follow types of functions when calculating dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

Issue 1019923005: Dart2js deferred loading. Follow types of functions when calculating dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Responding to review + Adding a computeSignature call. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

index 9a5c8e987940a9ec62bb27bc9291ab808012f7ee..99c46ca8a3461756540770966cb1519263428a79 100644

--- a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

@@ -193,6 +193,7 @@ class CustomElementsAnalysisJoin {

if (member.isGenerativeConstructor) {

// Ignore constructors that cannot be called with zero arguments.

FunctionElement constructor = member;

+ constructor.computeSignature(compiler);

FunctionSignature parameters = constructor.functionSignature;

if (parameters.requiredParameterCount == 0) {

result.add(member);

« pkg/compiler/lib/src/deferred_load.dart ('K') | « pkg/compiler/lib/src/elements/modelx.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »