Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: pkg/compiler/lib/src/typechecker.dart

Issue 1019923005: Dart2js deferred loading. Follow types of functions when calculating dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added test for generic type Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | tests/language/deferred_regression_22995_lib.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/typechecker.dart
diff --git a/pkg/compiler/lib/src/typechecker.dart b/pkg/compiler/lib/src/typechecker.dart
index 078086c823def58beca12c5ff43afed21d522686..c126bd237deba192ee612929b857b15d0eba502e 100644
--- a/pkg/compiler/lib/src/typechecker.dart
+++ b/pkg/compiler/lib/src/typechecker.dart
@@ -912,18 +912,18 @@ class TypeCheckerVisitor extends Visitor<DartType> {
if (error) {
// TODO(johnniwinther): Improve access to declaring element and handle
// synthesized member signatures. Currently function typed instance
- // members provide no access to there own name.
+ // members provide no access to their own name.
if (element == null) {
element = type.element;
- } else if (type.element.isTypedef) {
- if (element != null) {
- reportTypeInfo(element,
- MessageKind.THIS_IS_THE_DECLARATION,
- {'name': element.name});
- }
+ } else if (type.isTypedef) {
+ reportTypeInfo(element,
+ MessageKind.THIS_IS_THE_DECLARATION,
+ {'name': element.name});
element = type.element;
}
- reportTypeInfo(element, MessageKind.THIS_IS_THE_METHOD);
+ if (element != null) {
+ reportTypeInfo(element, MessageKind.THIS_IS_THE_METHOD);
+ }
}
} else {
while(!arguments.isEmpty) {
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | tests/language/deferred_regression_22995_lib.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698