Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1019883002: [turbofan] Add explicit set for nodes with weakened types. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add explicit set for nodes with weakened types. To ensure termination, we need to be sure that once we start weakening a node, we keep weakening that node in subsequent re-typings. Until now, we were guessing that we previously weakened from the type. This change introduces a set of nodes that have already be weakened, so that we have a reliable way to detect previous weakening. BUG=chromium:468799 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/adb8867337b75282f9e61251d015b77d4f92ad6b Cr-Commit-Position: refs/heads/master@{#27331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M src/compiler/typer.cc View 7 chunks +37 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-19 16:35:55 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-19 17:08:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019883002/1
5 years, 9 months ago (2015-03-20 09:10:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 09:12:48 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 09:13:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adb8867337b75282f9e61251d015b77d4f92ad6b
Cr-Commit-Position: refs/heads/master@{#27331}

Powered by Google App Engine
This is Rietveld 408576698