Show the details panel when file manager is first opened...on an import location. Adjust width and …

Show the details panel when file manager is first opened...on an import location. Adjust width and position of details panel to avoid line-wrapping main line.

BUG=464562
TEST=manual

TBR=fukino  // for minor CSS tweaks

Committed: https://crrev.com/cb503d1861c9e26be4c98a2ca95fa9bf1c815476
Cr-Commit-Position: refs/heads/master@{#321432}

[Steve McKay, 2015-03-19 18:23:49]

smckay@chromium.org changed reviewers:
+ kenobi@google.com

[Steve McKay, 2015-03-19 18:23:49]

smckay@chromium.org changed reviewers:
+ kenobi@google.com

[Steve McKay, 2015-03-19 19:03:48]

smckay@chromium.org changed reviewers:
+ kenobi@chromium.org
- kenobi@google.com

[Ben Kwa, 2015-03-19 19:06:56]

Couple of jsdoc nits, but otherwise lgtm.

https://codereview.chromium.org/1019833003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/import_controller.js (right):

https://codereview.chromium.org/1019833003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/import_controller.js:152: /**
@private */
Needs a param jsdoc.

https://codereview.chromium.org/1019833003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/import_controller.js:420: * Directly
sets the visibility of the details panel.
Needs a param jsdoc.

[Steve McKay, 2015-03-19 19:08:49]

Respond to review comments.

[Steve McKay, 2015-03-19 19:09:19]

Thanks!

https://codereview.chromium.org/1019833003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/import_controller.js (right):

https://codereview.chromium.org/1019833003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/import_controller.js:152: /**
@private */
On 2015/03/19 19:06:56, Ben Kwa wrote:
> Needs a param jsdoc.

Done.

https://codereview.chromium.org/1019833003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/import_controller.js:420: * Directly
sets the visibility of the details panel.
On 2015/03/19 19:06:56, Ben Kwa wrote:
> Needs a param jsdoc.

Done.

[Steve McKay, 2015-03-19 19:09:23]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-03-19 19:09:24]

The patchset sent to the CQ was uploaded after l-g-t-m from kenobi@chromium.org
Link to the patchset: https://codereview.chromium.org/1019833003/#ps20001
(title: "Respond to review comments.")

[commit-bot: I haz the power, 2015-03-19 19:10:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019833003/20001

[commit-bot: I haz the power, 2015-03-19 20:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 20:14:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Steve McKay, 2015-03-19 20:52:44]

Add test coverage.

[Steve McKay, 2015-03-19 20:52:47]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-03-19 20:52:47]

The patchset sent to the CQ was uploaded after l-g-t-m from kenobi@chromium.org
Link to the patchset: https://codereview.chromium.org/1019833003/#ps40001
(title: "Add test coverage.")

[commit-bot: I haz the power, 2015-03-19 20:52:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019833003/40001

[commit-bot: I haz the power, 2015-03-19 21:22:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-19 21:23:20]

Patchset 3 (id:??) landed as
https://crrev.com/cb503d1861c9e26be4c98a2ca95fa9bf1c815476
Cr-Commit-Position: refs/heads/master@{#321432}