Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1019803006: ozone: evdev: Use real initializer MockTouchEventConverterEvdev (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Use real initializer MockTouchEventConverterEvdev Use the captured description of the touchscreen for Chromebook Pixel to initialize the mock touchscreen, instead of just faking a couple of the members and leaving the rest uninitialized. The press, release, & move tests are merged into one test using real captured data from the Pixel touchscreen. The other tests just got their "pressure" values rescaled to the new axis. Now we can add a test that pases in a non-MT device description. BUG=461518 TEST=events_unittests Committed: https://crrev.com/c85426f444de061f8d75f59c63f94f48a2490232 Cr-Commit-Position: refs/heads/master@{#322607}

Patch Set 1 #

Patch Set 2 : remove stray event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -117 lines) Patch
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 14 chunks +84 lines, -117 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
spang
on top of https://codereview.chromium.org/1019793011/
5 years, 9 months ago (2015-03-25 23:41:51 UTC) #2
kpschoedel
lgtm
5 years, 9 months ago (2015-03-26 14:58:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019803006/20001
5 years, 9 months ago (2015-03-27 17:54:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 18:20:01 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 18:21:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c85426f444de061f8d75f59c63f94f48a2490232
Cr-Commit-Position: refs/heads/master@{#322607}

Powered by Google App Engine
This is Rietveld 408576698