Add browser tests for loading notification icons from blob and data URLs.

Add browser tests for loading notification icons from blob and data URLs.

These browser tests verify that we can load notification icons from
data: URLs and blobs when displaying Web Notifications.

R=johnme@chromium.org
BUG=none

Committed: https://crrev.com/3d25aae462af28669da65a6c3d33628d81389e23
Cr-Commit-Position: refs/heads/master@{#321359}

[johnme, 2015-03-19 12:24:29]

lgtm % nits

https://codereview.chromium.org/1019803002/diff/1/chrome/test/data/notificati...
File chrome/test/data/notifications/platform_notification_service.html (right):

https://codereview.chromium.org/1019803002/diff/1/chrome/test/data/notificati...
chrome/test/data/notifications/platform_notification_service.html:61: // Helper
function to request icon.png, returns a promise that will be
Nit: you could just use fetch

https://codereview.chromium.org/1019803002/diff/1/chrome/test/data/notificati...
chrome/test/data/notifications/platform_notification_service.html:84: string[i]
= String.fromCharCode(uint8Array[i]);
I'm a little freaked out by the need to convert everything to string characters.
It would probably be neater to use FileReader.readAsDataURL (taking a blob from
fetch): http://stackoverflow.com/a/18650249

[Peter Beverloo, 2015-03-19 12:30:02]

Thanks for the review!

https://codereview.chromium.org/1019803002/diff/1/chrome/test/data/notificati...
File chrome/test/data/notifications/platform_notification_service.html (right):

https://codereview.chromium.org/1019803002/diff/1/chrome/test/data/notificati...
chrome/test/data/notifications/platform_notification_service.html:61: // Helper
function to request icon.png, returns a promise that will be
On 2015/03/19 12:24:29, johnme wrote:
> Nit: you could just use fetch

Done.

https://codereview.chromium.org/1019803002/diff/1/chrome/test/data/notificati...
chrome/test/data/notifications/platform_notification_service.html:84: string[i]
= String.fromCharCode(uint8Array[i]);
On 2015/03/19 12:24:29, johnme wrote:
> I'm a little freaked out by the need to convert everything to string
characters.
> It would probably be neater to use FileReader.readAsDataURL (taking a blob
from
> fetch): http://stackoverflow.com/a/18650249

Done.

[Peter Beverloo, 2015-03-19 12:30:21]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-19 12:30:22]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org
Link to the patchset: https://codereview.chromium.org/1019803002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2015-03-19 12:30:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019803002/20001

[commit-bot: I haz the power, 2015-03-19 15:00:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-19 15:01:42]

Patchset 2 (id:??) landed as
https://crrev.com/3d25aae462af28669da65a6c3d33628d81389e23
Cr-Commit-Position: refs/heads/master@{#321359}