Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1019793011: ozone: evdev: Add absolute axis information to DeviceCapabilities (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Add absolute axis information to DeviceCapabilities We'll need this to do touchscreen (and other absolute) device testing with real event dumps as input since the axis information must be valid. Replace the shell script to capture capabilities with a python script, because the absolute axis bounds aren't exposed in sysfs. We have python-evdev on test images. Unfortunately it's a bit incomplete & buggy, so fall back to sysfs for the missing & incorrect bits. The "sw" field was accidently omitted previously and is now populated. BUG=none TEST=events_unittests Committed: https://crrev.com/4ff8f3ee664038e3617d093439dc6cfed1e1b8ed Cr-Commit-Position: refs/heads/master@{#322384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -24 lines) Patch
A ui/events/ozone/evdev/capture_device_capabilities.py View 1 chunk +136 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_device_test_util.h View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_device_test_util.cc View 12 chunks +79 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 9 months ago (2015-03-25 22:55:25 UTC) #2
kpschoedel
LGTM
5 years, 9 months ago (2015-03-26 14:46:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019793011/1
5 years, 9 months ago (2015-03-26 14:49:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 15:12:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 15:13:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff8f3ee664038e3617d093439dc6cfed1e1b8ed
Cr-Commit-Position: refs/heads/master@{#322384}

Powered by Google App Engine
This is Rietveld 408576698