Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019793008: Deprecate IdleNotification() (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate IdleNotification() Embedders should use IdleNotificationDeadline() BUG=none R=hpayer@chromium.org LOG=y Committed: https://crrev.com/3fbc0cb79a2e1208cc94309eda5205119f938fce Cr-Commit-Position: refs/heads/master@{#27550}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M include/v8.h View 1 2 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-24 12:54:23 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-24 13:06:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019793008/1
5 years, 9 months ago (2015-03-26 15:30:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4270)
5 years, 9 months ago (2015-03-26 15:32:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019793008/20001
5 years, 8 months ago (2015-03-31 10:38:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/4506)
5 years, 8 months ago (2015-03-31 10:40:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019793008/40001
5 years, 8 months ago (2015-03-31 16:40:58 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-31 17:11:18 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 17:11:27 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3fbc0cb79a2e1208cc94309eda5205119f938fce
Cr-Commit-Position: refs/heads/master@{#27550}

Powered by Google App Engine
This is Rietveld 408576698