Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1019783003: Pull in specific revision of PDF corpus via DEPS. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull in specific revision of PDF corpus via DEPS. There are two reasons for doing this. The first is that adding files to this repository doesn't trigger a rebuild on the bot, so the next unrelated pdfium change will be the one to hit any issues with the unversioned corpus. The second is that we may need a specific version of the expected output files (.pngs) to go with a specific pdfium build. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/76a61ca39a235dbe4c5df5fca93e1cfff8879113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, please review (mainly the CL description).
5 years, 9 months ago (2015-03-19 21:16:52 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-19 21:25:49 UTC) #3
Tom Sepez
5 years, 9 months ago (2015-03-19 21:35:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76a61ca39a235dbe4c5df5fca93e1cfff8879113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698