Issue 1019773004: Port to real Sk2f.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1019773004: Port to real Sk2f. (Closed)

Created:
5 years, 9 months ago by mtklein_C

Modified:
5 years, 9 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Port to real Sk2f. The bench improves from 39 to 30, about half from porting to Sk2f, half from x.add(x) instead of x.multiply(two). Remove Sk4f Load2/store2 now that we have Sk2f. BUG=skia: Committed: https://skia.googlesource.com/skia/+/950e986b1bc127af1f484572d2494091957486f9

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -35 lines)			Patch
M	src/core/Sk4x.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/core/SkGeometry.cpp	View	3 chunks	+14 lines, -14 lines	0 comments	Download
M	tests/Sk4xTest.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019773004/1

5 years, 9 months ago (2015-03-19 17:47:13 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 9 months ago (2015-03-19 17:47:14 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-19 19:03:32 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/950e986b1bc127af1f484572d2494091957486f9