Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1019763002: Added test to ensure app banner settings are per-origin. (Closed)

Created:
5 years, 9 months ago by benwells
Modified:
5 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added test to ensure app banner settings are per-origin. The banner engagement persisted data should be per-origin. This test ensures that is the case. BUG=468148 Committed: https://crrev.com/500bbc41a2711ee5ba4d22ae4b3d16fa5867d30a Cr-Commit-Position: refs/heads/master@{#321409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/banners/app_banner_settings_helper_unittest.cc View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 9 months ago (2015-03-19 07:54:27 UTC) #2
gone
lgtm
5 years, 9 months ago (2015-03-19 16:46:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019763002/1
5 years, 9 months ago (2015-03-19 19:24:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 19:37:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:38:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/500bbc41a2711ee5ba4d22ae4b3d16fa5867d30a
Cr-Commit-Position: refs/heads/master@{#321409}

Powered by Google App Engine
This is Rietveld 408576698