src/lazy/SkDiscardablePixelRef.cpp - Issue 101973005: SkDecodingImageGenerator now uses SkStreamRewindable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lazy/SkDiscardablePixelRef.cpp

Issue 101973005: SkDecodingImageGenerator now uses SkStreamRewindable (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lazy/SkDiscardablePixelRef.cpp

diff --git a/src/lazy/SkDiscardablePixelRef.cpp b/src/lazy/SkDiscardablePixelRef.cpp

index e614db37e98589678919002432f1d9feb687f6d5..b155b262a43f2fb3b1c29c158424b290f6c4da7a 100644

--- a/src/lazy/SkDiscardablePixelRef.cpp

+++ b/src/lazy/SkDiscardablePixelRef.cpp

@@ -70,7 +70,8 @@ bool SkDiscardablePixelRef::Install(SkImageGenerator* generator,

if ((NULL == generator)

|| (!generator->getInfo(&info))

|| (!dst->setConfig(info, 0))

- || (0 == dst->getSize())) { // dst->getSize=0 Probably a bad config

+ || (0 == dst->getSize())

+ || (0 == dst->rowBytes())) {

SkDELETE(generator);

return false;

}