Issue 1019723002: Fix hit-testing in the stocks apps when scrolled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1019723002: Fix hit-testing in the stocks apps when scrolled. (Closed)

Created:
5 years, 9 months ago by ojan

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix hit-testing in the stocks apps when scrolled. We were not passing the transformed HitTestLocation when we recursed into child layers, which meant that we wouldn't take transforms correctly into account when hit testing. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b8a20e08dcef80caccab4235d42a0c3cbae59234

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -1 line)			Patch
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	sky/tests/layout/clipping-elementFromPoint.sky	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	sky/tests/layout/clipping-elementFromPoint-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 9 months ago (2015-03-19 01:55:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8a20e08dcef80caccab4235d42a0c3cbae59234 (presubmit successful).