Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: trychange.py

Issue 1019713002: git try -t support for Gerrit (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 719275a12c9e355a44654ec3e90c06a7d0b58731..03e59b37f7189e9fe2eadd9f2c664a3cf72583a4 100755
--- a/trychange.py
+++ b/trychange.py
@@ -727,6 +727,7 @@ def _SendChangeGerrit(bot_spec, options):
Gerrit message format: starts with !tryjob, optionally followed by a tryjob
definition in JSON format:
buildNames: list of strings specifying build names.
+ build_properties: a dict of build properties.
"""
logging.info('Sending by Gerrit')
@@ -752,9 +753,14 @@ def _SendChangeGerrit(bot_spec, options):
def FormatMessage():
# Build job definition.
job_def = {}
+ build_properties = {}
+ if options.testfilter:
+ build_properties['testfilter'] = options.testfilter
builderNames = [builder for builder, _ in bot_spec]
if builderNames:
job_def['builderNames'] = builderNames
+ if build_properties:
+ job_def['build_properties'] = build_properties
# Format message.
msg = '!tryjob'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698