git try -t support for Gerrit

git try -t support for Gerrit

If testfilter parameter is passed, put it in to the gerrit tryjob
as a property. Later it will be processed by GerritPoller on Buildbot
master.

R=victorhsieh@chromium.org
BUG=468075
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294500

[nodir, 2015-03-19 00:36:40]

PTAL

[victorhsieh, 2015-03-19 16:20:44]

lgtm

Thanks!

[nodir, 2015-03-19 16:25:54]

The CQ bit was checked by nodir@chromium.org

[nodir, 2015-03-19 16:25:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
victorhsieh@chromium.org
Link to the patchset: https://codereview.chromium.org/1019713002/#ps20001
(title: "typo")

[commit-bot: I haz the power, 2015-03-19 16:26:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019713002/20001

[commit-bot: I haz the power, 2015-03-19 16:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 16:29:46]

Presubmit check for 1019713002-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (54.44s) failed
Ffatal: reference is not a tree: 9cf371c7cda13ecced4a5feb896898af5907fbb4
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
9cf371c7cda13ecced4a5feb896898af5907fbb4 returned non-zero exit status 128 in
/tmp/trial8Algp4/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trial8Algp4/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trial8Algp4/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 53.221s

FAILED (failures=1, errors=2)


Presubmit checks took 216.2s to calculate.

[nodir, 2015-03-19 16:37:06]

Committed patchset #2 (id:20001) manually as 294500.

[dmichael (off chromium), 2015-03-19 19:21:25]

dmichael@chromium.org changed reviewers:
+ dmichael@chromium.org

[dmichael (off chromium), 2015-03-19 19:21:25]

I'm getting an error this afternoon from git cl try locally. Any chance it's
related to this change?
"""Usage: git cl try [options]

git cl: error: No default try builder to try, use --bot
"""

[nodir, 2015-03-19 19:42:45]

This change affects only gerrit code path. Do you use gerrit?

On Thu, Mar 19, 2015, 12:21 PM null <dmichael@chromium.org> wrote:

> I'm getting an error this afternoon from git cl try locally. Any chance
> it's
> related to this change?
> """Usage: git cl try [options]
>
> git cl: error: No default try builder to try, use --bot
> """
>
> https://codereview.chromium.org/1019713002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmichael (off chromium), 2015-03-19 19:51:54]

On 2015/03/19 19:42:45, nodir wrote:
> This change affects only gerrit code path. Do you use gerrit?
> 
Nope. Looking like it's unrelated; it was just a weird coincidence that this had
landed so recently. Sorry for the noise.

> On Thu, Mar 19, 2015, 12:21 PM null <mailto:dmichael@chromium.org> wrote:
> 
> > I'm getting an error this afternoon from git cl try locally. Any chance
> > it's
> > related to this change?
> > """Usage: git cl try [options]
> >
> > git cl: error: No default try builder to try, use --bot
> > """
> >
> > https://codereview.chromium.org/1019713002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.