Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: sky/framework/components/button_base.dart

Issue 1019633004: Change how events are handled in Effen (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/stocks-fn/lib/stock_app.dart ('k') | sky/framework/components/checkbox.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/button_base.dart
diff --git a/sky/framework/components/button_base.dart b/sky/framework/components/button_base.dart
index 40c131d57134e19efcf10d741e532eccade87b27..1152c03c6f25733e3563a30b93fe1672dadda0b4 100644
--- a/sky/framework/components/button_base.dart
+++ b/sky/framework/components/button_base.dart
@@ -7,10 +7,17 @@ import '../fn.dart';
abstract class ButtonBase extends Component {
bool highlight = false;
- ButtonBase({ Object key }) : super(key: key) {
- events.listen('pointerdown', _handlePointerDown);
- events.listen('pointerup', _handlePointerUp);
- events.listen('pointercancel', _handlePointerCancel);
+ ButtonBase({ Object key }) : super(key: key);
+
+ Node buildContent();
+
+ Node build() {
+ return new EventTarget(
+ buildContent(),
+ onPointerDown: _handlePointerDown,
+ onPointerUp: _handlePointerUp,
+ onPointerCancel: _handlePointerCancel
+ );
}
void _handlePointerDown(_) {
« no previous file with comments | « sky/examples/stocks-fn/lib/stock_app.dart ('k') | sky/framework/components/checkbox.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698