Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 1019633003: Improve accessibility test for input type=password (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 8 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve accessibility test for input type=password Test that we're exposing the cursor position correctly and that the value is replaced with bullets. Depends on: https://codereview.chromium.org/1009543009/ BUG=84250 Committed: https://crrev.com/7258e96e6072a99370ea4061e827f944dd48dcbb Cr-Commit-Position: refs/heads/master@{#326759}

Patch Set 1 #

Patch Set 2 : Re-enabled test #

Patch Set 3 : Update expectation #

Patch Set 4 : Fix test output filter #

Patch Set 5 : Update Mac and Android expectations too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 4 1 chunk +1 line, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-password.html View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/input-password-expected-android.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-password-expected-mac.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-password-expected-win.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
dmazzoni
5 years, 9 months ago (2015-03-18 21:29:16 UTC) #2
aboxhall
lgtm
5 years, 9 months ago (2015-03-18 21:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019633003/20001
5 years, 9 months ago (2015-03-24 05:10:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/66879)
5 years, 9 months ago (2015-03-24 06:18:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019633003/40001
5 years, 8 months ago (2015-04-17 21:45:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/58467)
5 years, 8 months ago (2015-04-17 21:54:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019633003/60001
5 years, 8 months ago (2015-04-23 22:40:14 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/58783)
5 years, 8 months ago (2015-04-24 01:02:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019633003/80001
5 years, 8 months ago (2015-04-24 06:40:29 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-24 08:31:30 UTC) #22
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 08:32:24 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7258e96e6072a99370ea4061e827f944dd48dcbb
Cr-Commit-Position: refs/heads/master@{#326759}

Powered by Google App Engine
This is Rietveld 408576698