Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1019633002: Initial change to move text blob to GrTextContext (Closed)

Created:
5 years, 9 months ago by joshua.litt
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@text-blob2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initial change to move text blob to GrTextContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/9c328187d9dee33736b77dc14dfb59529d948bb1

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Patch Set 3 : more correct #

Patch Set 4 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M include/core/SkTextBlob.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 3 chunks +70 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
joshualitt
The logic mostly comes from SkDevice.cpp
5 years, 9 months ago (2015-03-18 19:59:46 UTC) #2
robertphillips
looks good to me but I would again like Jim to chime in https://codereview.chromium.org/1019633002/diff/1/src/gpu/GrTextContext.h File ...
5 years, 9 months ago (2015-03-18 20:05:12 UTC) #3
joshualitt
On 2015/03/18 20:05:12, robertphillips wrote: > looks good to me but I would again like ...
5 years, 9 months ago (2015-03-19 17:06:36 UTC) #4
jvanverth1
On 2015/03/19 17:06:36, joshualitt wrote: > On 2015/03/18 20:05:12, robertphillips wrote: > > looks good ...
5 years, 9 months ago (2015-03-20 17:19:52 UTC) #5
joshualitt
Adding Reed for public api lgtm
5 years, 9 months ago (2015-03-20 17:24:20 UTC) #7
joshualitt
On 2015/03/20 17:24:20, joshualitt wrote: > Adding Reed for public api lgtm Reed, can you ...
5 years, 9 months ago (2015-03-23 15:00:55 UTC) #8
reed1
lgtm
5 years, 9 months ago (2015-03-23 15:04:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019633002/60001
5 years, 9 months ago (2015-03-23 15:07:47 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 15:13:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9c328187d9dee33736b77dc14dfb59529d948bb1

Powered by Google App Engine
This is Rietveld 408576698