Remove DisplayState from the public interface for DisplayConfigurator

Remove DisplayState from the public interface for DisplayConfigurator

The extra fields in DisplayState were only used internally and we don't
need to keep track of them. We can simply compute them when performing
the display configuration.

This is a refactor, no functional change intended.

BUG=none

Committed: https://crrev.com/5cc656d7160107491cdebdefd8752ff013f12521
Cr-Commit-Position: refs/heads/master@{#321372}

[dnicoara, 2015-03-18 20:01:49]

dnicoara@chromium.org changed reviewers:
+ oshima@chromium.org

[dnicoara, 2015-03-18 20:01:50]

PTAL

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:561: for
(DisplayStateList::const_iterator it = cached_displays_.begin();
I was thinking of converting these for-loops to c++11 style for better clarity.
I was thinking of doing it as a followup to keep this CL small. What do you
think?

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.h (right):

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.h:45: typedef
std::vector<DisplaySnapshot*> DisplayStateList;
I was thinking of renaming this as well. My though was just simplify it to
"DisplayList". What do you think?

[oshima, 2015-03-18 23:02:45]

nice. just minor nits.

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:561: for
(DisplayStateList::const_iterator it = cached_displays_.begin();
On 2015/03/18 20:01:49, dnicoara wrote:
> I was thinking of converting these for-loops to c++11 style for better
clarity.
> I was thinking of doing it as a followup to keep this CL small. What do you
> think?

sg

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.h (right):

https://codereview.chromium.org/1019623002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.h:45: typedef
std::vector<DisplaySnapshot*> DisplayStateList;
On 2015/03/18 20:01:50, dnicoara wrote:
> I was thinking of renaming this as well. My though was just simplify it to
> "DisplayList". What do you think?

I don't have strong opinion, but I'd prefer to keep it something not DisplayList
because there is gfx::Display.

https://codereview.chromium.org/1019623002/diff/20001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.cc:88: it != output.modes().end();
++it) {
can we use range based for loop?

https://codereview.chromium.org/1019623002/diff/20001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.cc:175: const ui::DisplaySnapshot&
state = *display_states[i];
ditto

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/lock_state_contr...
File ash/wm/lock_state_controller_unittest.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/lock_state_contr...
ash/wm/lock_state_controller_unittest.cc:924:
external_display.set_current_mode(NULL);
nullptr

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/power_button_con...
File ash/wm/power_button_controller.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/power_button_con...
ash/wm/power_button_controller.cc:148: for (size_t i = 0; i <
display_states.size(); ++i) {
ditto

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/dis...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/dis...
ui/display/chromeos/display_configurator.cc:39: DisplaySnapshot* display;  //
Not owned.
you can initialize them here now. (it's new in c++11)

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/upd...
File ui/display/chromeos/update_display_configuration_task_unittest.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/upd...
ui/display/chromeos/update_display_configuration_task_unittest.cc:66: mode =
nullptr;
ternary operator?

[dnicoara, 2015-03-19 14:47:36]

Also found a few places in extensions/* that required updates.

https://codereview.chromium.org/1019623002/diff/20001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.cc:88: it != output.modes().end();
++it) {
On 2015/03/18 23:02:45, oshima wrote:
> can we use range based for loop?

Done.

https://codereview.chromium.org/1019623002/diff/20001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.cc:175: const ui::DisplaySnapshot&
state = *display_states[i];
On 2015/03/18 23:02:45, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/lock_state_contr...
File ash/wm/lock_state_controller_unittest.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/lock_state_contr...
ash/wm/lock_state_controller_unittest.cc:924:
external_display.set_current_mode(NULL);
On 2015/03/18 23:02:45, oshima wrote:
> nullptr

Done.

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/power_button_con...
File ash/wm/power_button_controller.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ash/wm/power_button_con...
ash/wm/power_button_controller.cc:148: for (size_t i = 0; i <
display_states.size(); ++i) {
On 2015/03/18 23:02:45, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/dis...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/dis...
ui/display/chromeos/display_configurator.cc:39: DisplaySnapshot* display;  //
Not owned.
On 2015/03/18 23:02:45, oshima wrote:
> you can initialize them here now. (it's new in c++11)

Done.

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/upd...
File ui/display/chromeos/update_display_configuration_task_unittest.cc (right):

https://codereview.chromium.org/1019623002/diff/20001/ui/display/chromeos/upd...
ui/display/chromeos/update_display_configuration_task_unittest.cc:66: mode =
nullptr;
On 2015/03/18 23:02:45, oshima wrote:
> ternary operator?

Done.

[oshima, 2015-03-19 15:22:08]

lgtm

[dnicoara, 2015-03-19 15:23:24]

dnicoara@chromium.org changed reviewers:
+ jamescook@chromium.org

[dnicoara, 2015-03-19 15:23:24]

+ jamescook@ for extensions/* review

[James Cook, 2015-03-19 15:36:53]

extensions/shell LGTM

[dnicoara, 2015-03-19 15:38:40]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-03-19 15:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019623002/40001

[commit-bot: I haz the power, 2015-03-19 16:40:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-19 16:40:42]

Patchset 3 (id:??) landed as
https://crrev.com/5cc656d7160107491cdebdefd8752ff013f12521
Cr-Commit-Position: refs/heads/master@{#321372}